From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 940B0C07E95 for ; Wed, 7 Jul 2021 08:14:45 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 1EF7A61C73 for ; Wed, 7 Jul 2021 08:14:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EF7A61C73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1936406B4; Wed, 7 Jul 2021 10:14:43 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 622124069D for ; Wed, 7 Jul 2021 10:14:42 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="207438024" X-IronPort-AV: E=Sophos;i="5.83,331,1616482800"; d="scan'208";a="207438024" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2021 01:14:35 -0700 X-IronPort-AV: E=Sophos;i="5.83,331,1616482800"; d="scan'208";a="497663386" Received: from jweldon-mobl.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.4.148]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 07 Jul 2021 01:14:34 -0700 Date: Wed, 7 Jul 2021 09:14:30 +0100 From: Bruce Richardson To: fengchengwen Cc: dev@dpdk.org, Jerin Jacob , Jerin Jacob , Morten =?iso-8859-1?Q?Br=F8rup?= Message-ID: References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <20210706202841.661302-1-bruce.richardson@intel.com> <32b9fa47-918b-cb16-d4c1-729ee92ba6f4@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32b9fa47-918b-cb16-d4c1-729ee92ba6f4@huawei.com> Subject: Re: [dpdk-dev] [RFC UPDATE PATCH 0/9] dmadev rfc suggested updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 07, 2021 at 11:16:44AM +0800, fengchengwen wrote: > LGTM, thanks > > And I'am prepare dmadev V2, include: a) Fix code review comments (e.g. > multiple-process support, doxygen, comments, typo) b) Flatten device > abstraction to two layer: dmadev <> vchan c) Public API use dev_id and > vchan_id to locate one vchan d) Using the flags parameter instead of the > fence API e) Rename rte_dmadev_perform to rte_dmadev_submit so it > corresponds to the stats variable. > > PS: Some code (lib/dmadev) will rebase this patchset > > As well as posting the RFC v2 here, could you also perhaps post it to a github repo, so that Jerin, myself and others can send pull-requests with suggested changes? For key areas of discussion, working through github with patches sent via pull request you can take in directly will probably be faster for getting us to a v3. The mail threads on list are already getting very long and hard to follow. Regards, /Bruce