From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 641E2C11F66 for ; Wed, 7 Jul 2021 18:44:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A18261CCB for ; Wed, 7 Jul 2021 18:44:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A18261CCB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3853C82E05; Wed, 7 Jul 2021 20:44:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="nFQyfNCY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B887F82E0B; Wed, 7 Jul 2021 20:44:43 +0200 (CEST) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1F60B82DFA for ; Wed, 7 Jul 2021 20:44:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x431.google.com with SMTP id q17so4228262wrv.2 for ; Wed, 07 Jul 2021 11:44:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ntrk/Em8mlf6AinYlNV73x0jBWC3H4hx3ayB7C8vBvg=; b=nFQyfNCYT8NIqwF1Srpvy0RdsED4ifALkhSrqy1/eXVyYS5PxklCZyM5DRqtSpyYFl iBHTDh6EO8gZgwrPLm5wG8VPy0k2fcO9QV0YcxEs66OHaBzWn4iaZLCr0J+WSaiYXWiV /JEAlK99busNg7FFdZnb4h5U5J5YFWYMSv9HRqctbuMMnt3TwedFIYPs2kG6tSS2ZB3i jKsnyge9ju3yzwoLg/E1oWrDAuFQZ3zpbVmfUmkHY4EQiaoaDpphto3JeN49P8dnVXpa vRMG0SNxDvHJqDhzsPXrX6aV4//0NFqoO8kS31b1tKmod02e1Q1y+uZDcBogTmADULoM hvmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ntrk/Em8mlf6AinYlNV73x0jBWC3H4hx3ayB7C8vBvg=; b=CYZyHHH0nHwGqlZ1fPgLCg73XGw95Iq+4g8XBUYN0t5LPkfk9FEId5whF4cbufBOEj tjaX416kS3p3G+vdWQuTy6vi7pTj2wFbrfTaJQAk3pvZVIKvQfUxRg2M5Seou9JiMalK YxYns/6Y+JzSL7uBjo8dHyO3ccCdavRgLUTAzHf2sbMNkLlkxSnWeu0382pqeADD7DEA CncmJa3tTR9x57qPf7XXbTGMvFZLYXHlJWieKUdie9D8m+kNvcgsOgnfbCnJ+mD5Q5bH SCqr9/bgFeE+jLeQ+tPK8w5iz5qYUMgjCo/fwSEDX1V11aJI7dZgiedc5tllsVCXtj+j qhOw== X-Gm-Message-State: AOAM533HLmU262sddcOASQWDF+61tO7GtwKszkoUWvOsNh4NWu5acBMK UE74Ie7daQ0FGjU5HO3BzxgzxA== X-Google-Smtp-Source: ABdhPJxGDS3rNcIGMISsRh2YrxHxLTcZil25jyisxWQhikajyYwIwhgNoUpWPB0iac4OhFZEObdnxw== X-Received: by 2002:adf:dd0d:: with SMTP id a13mr9287852wrm.220.1625683480604; Wed, 07 Jul 2021 11:44:40 -0700 (PDT) Received: from enceladus (ppp-94-66-242-227.home.otenet.gr. [94.66.242.227]) by smtp.gmail.com with ESMTPSA id 25sm19874284wmf.21.2021.07.07.11.44.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 11:44:40 -0700 (PDT) Date: Wed, 7 Jul 2021 21:44:37 +0300 From: Ilias Apalodimas To: Simon Glass Cc: Masahisa Kojima , Heinrich Schuchardt , Alexander Graf , Dhananjay Phadke , U-Boot Mailing List Subject: Re: [PATCH 2/5] efi_loader: add secure boot variable measurement Message-ID: References: <20210707133638.12630-1-masahisa.kojima@linaro.org> <20210707133638.12630-3-masahisa.kojima@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, Jul 07, 2021 at 11:49:33AM -0600, Simon Glass wrote: > Hi Ilias, > > On Wed, 7 Jul 2021 at 11:40, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Wed, Jul 07, 2021 at 11:37:01AM -0600, Simon Glass wrote: > > > Hi Masahisa, > > > > > > On Wed, 7 Jul 2021 at 07:36, Masahisa Kojima wrote: > > > > > > > > TCG PC Client PFP spec requires to measure the secure > > > > boot policy before validating the UEFI image. > > > > This commit adds the secure boot variable measurement > > > > of "SecureBoot", "PK", "KEK", "db" and "dbx". > > > > > > > > Note that this implementation assumes that secure boot > > > > variables are pre-configured and not be set/updated in runtime. > > > > > > > > Signed-off-by: Masahisa Kojima > > > > --- > > > > include/efi_tcg2.h | 20 ++++++ > > > > lib/efi_loader/efi_tcg2.c | 135 ++++++++++++++++++++++++++++++++++++++ > > > > 2 files changed, 155 insertions(+) > > > > > > Where are the tests for this code, please? > > > > As we discussed in the past, the EFI TCG code can't be tested with the > > asndbox as-is. I'll have a look on your sandbox patches in case we can now > > use those, but in any case, I've sent a TPM mmio based driver. Even if the > > sandbox is still not enough we can add tests once the mmio TPM driver gets > > merged > > Can you add features to the sandbox driver? I just sent a series that > added nvdata, for example. Yea I've seen that, I was going to have a look. I'll try but my schedule is pretty tight atm. Thanks /Ilias > > Regards, > Simon