From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E58C6C07E9C for ; Wed, 7 Jul 2021 17:39:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3D8061CC2 for ; Wed, 7 Jul 2021 17:39:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231144AbhGGRm2 (ORCPT ); Wed, 7 Jul 2021 13:42:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:46968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229953AbhGGRm1 (ORCPT ); Wed, 7 Jul 2021 13:42:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6062F61CC8; Wed, 7 Jul 2021 17:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1625679586; bh=NslRH76i/hbV/A9scmjZZDgGzjzRzgIKHorn/EcZ2wo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oTDiEetQ92pV4HvL4v6T919GwtYVYqB887BNwSro7Y8TKe49tD5GFgh/rsCJ+ruOJ juCQBEOVSbz0hasdjlLA6yfaBhps/+T333BAr3ACVUBwLZdfyybZJuHv1ckK2pnu0+ sLQgKH4BQyFlwzAOGp1v9te+zSbTHiu+HrcvCarE= Date: Wed, 7 Jul 2021 19:39:44 +0200 From: Greg Kroah-Hartman To: Adrian Hunter Cc: "Rafael J . Wysocki" , Saravana Kannan , "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Avri Altman , Bean Huo , Can Guo , Asutosh Das , Bart Van Assche , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 2/2] scsi: ufshcd: Fix device links when BOOT WLUN fails to probe Message-ID: References: <20210707172948.1025-1-adrian.hunter@intel.com> <20210707172948.1025-3-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210707172948.1025-3-adrian.hunter@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 07, 2021 at 08:29:48PM +0300, Adrian Hunter wrote: > If a LUN fails to probe (e.g. absent BOOT WLUN), the device will not have > been registered but can still have a device link holding a reference to the > device. The unwanted device link will prevent runtime suspend indefinitely, > and cause some warnings if the supplier is ever deleted (e.g. by unbinding > the UFS host controller). Fix by explicitly deleting the device link when > SCSI destroys the SCSI device. > > Signed-off-by: Adrian Hunter > --- > drivers/scsi/ufs/ufshcd.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 708b3b62fc4d..483aa74fe2c8 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -5029,6 +5029,13 @@ static void ufshcd_slave_destroy(struct scsi_device *sdev) > spin_lock_irqsave(hba->host->host_lock, flags); > hba->sdev_ufs_device = NULL; > spin_unlock_irqrestore(hba->host->host_lock, flags); > + } else { > + /* > + * If a LUN fails to probe (e.g. absent BOOT WLUN), the device > + * will not have been registered but can still have a device > + * link holding a reference to the device. > + */ > + device_links_scrap(&sdev->sdev_gendev); What created that link? And why did it do that before probe happened successfully? thanks, greg k-h