From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C359FC07E96 for ; Thu, 8 Jul 2021 04:08:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50C1061CDD for ; Thu, 8 Jul 2021 04:08:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50C1061CDD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1LKT-00068j-8a for qemu-devel@archiver.kernel.org; Thu, 08 Jul 2021 00:08:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1LFV-0001QF-Js; Thu, 08 Jul 2021 00:02:53 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:34529 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1LFR-0004eI-LR; Thu, 08 Jul 2021 00:02:53 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4GL2gk4Rkbz9sXL; Thu, 8 Jul 2021 14:02:42 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1625716962; bh=uhvlaHddDhqgoVtbefUJeN2mXymIWkgUZA6k40F3ZB0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PkBPfDowxQgG/MCtemnd2I/ESEqVLlgmW+iXxRxo2vZcecCpCpi3Am2uDeYD3Vcc8 8KpG02XIgaT0qJB3PX7NMTRLlXCA3g3J0YqxfEIsOaOdiZnjjGaP3dfLbnL+QHOmSu r7aO5vfH7VWgmvqRnV8n1dypMHYvC56BZgtmEgmM= Date: Thu, 8 Jul 2021 12:48:59 +1000 From: David Gibson To: BALATON Zoltan Subject: Re: [PATCH 2/4] target/ppc: Allow virtual hypervisor on CPU without HV Message-ID: References: <21c7745aabbb68fcc50bb2ffaf16b939ba21261c.1624811233.git.balaton@eik.bme.hu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QXBLzTNxfB/6l8Gd" Content-Disposition: inline In-Reply-To: <21c7745aabbb68fcc50bb2ffaf16b939ba21261c.1624811233.git.balaton@eik.bme.hu> Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --QXBLzTNxfB/6l8Gd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 27, 2021 at 06:27:13PM +0200, BALATON Zoltan wrote: > Change the assert in ppc_store_sdr1() to allow vhyp to be set on CPUs > without HV bit. This allows using the vhyp interface for firmware > emulation on pegasos2. >=20 > Signed-off-by: BALATON Zoltan Kind of a hack, but a simple one, so applied to ppc-for-6.1. > --- > target/ppc/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c > index 19d67b5b07..a29299882a 100644 > --- a/target/ppc/cpu.c > +++ b/target/ppc/cpu.c > @@ -72,7 +72,7 @@ void ppc_store_sdr1(CPUPPCState *env, target_ulong valu= e) > { > PowerPCCPU *cpu =3D env_archcpu(env); > qemu_log_mask(CPU_LOG_MMU, "%s: " TARGET_FMT_lx "\n", __func__, valu= e); > - assert(!cpu->vhyp); > + assert(!cpu->env.has_hv_mode || !cpu->vhyp); > #if defined(TARGET_PPC64) > if (mmu_is_64bit(env->mmu_model)) { > target_ulong sdr_mask =3D SDR_64_HTABORG | SDR_64_HTABSIZE; --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --QXBLzTNxfB/6l8Gd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmDmZ5sACgkQbDjKyiDZ s5JS5g//UEzBYK/LiaMAMEEL/ksCfvx+e7qV1w4mNE4zc76dYyltvCGu8Hbp5Ub8 1tvedmnzVUlqu9Uzi+N87uW40jOoK/wPQOKIriNAx/pOAcOYVlH7m9kEAcAOrU5R cz5DvBsyklapmsZdfLimGFUKuVGdvjfxYYZDK5kxWdTdF+FT9DV4bMEDVK21LUrA AqwkxVNL133qVuFHz5OnwZMRoC1+Nb5ICJTdmumNvhH7h1U36FTAZny01qLNe5WC /2VsffH544M8gvy5UKS9U6Ut8CH57D1bNbTTsAm10C6K8uJpoVsjh8+L8KxlAcnN QOOIZSOhn+TCmnZaQmFnY7IRFzfihU9rPD5rGsDkd3JlzI8/Tc9ZFZOGFPyWuWdZ R11DqqH3tHfXpuCzyGc1/23FC3NotbWMCDmPAMVyZlHfyA4+3ToG9fnK2Nmqk4RY dU+Ait9SVKQDuEVyWzMFyMbbfTkUaqYG5Q2/2RKaF0UA/foVvi1OYXRz+jrU8wTm NlAr2uj9Ri0tYu7SwI54kzV7Q6WpTs4X4KPLYBPmdA5I5Fg0fM/tlG8+fMpPPqql jbvTIfY73DKYn8Z+LsR0kpVc8fJkigHCKvF4nTeTvMZndiL+WO133oEGm35elHCM vdpk1O7U2qFPxi8+y2OFk+7ZZvh6Ic490mnrN0wfTqjjSaKltEA= =wM9b -----END PGP SIGNATURE----- --QXBLzTNxfB/6l8Gd--