From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E526C07E99 for ; Thu, 8 Jul 2021 17:21:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2056B617ED for ; Thu, 8 Jul 2021 17:21:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbhGHRYA (ORCPT ); Thu, 8 Jul 2021 13:24:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbhGHRX5 (ORCPT ); Thu, 8 Jul 2021 13:23:57 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1D8CC06175F for ; Thu, 8 Jul 2021 10:21:14 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id t9so6799183pgn.4 for ; Thu, 08 Jul 2021 10:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QCo14xV8rAUzfCQotnJU7VU371YftBdUOIgGhDFsTfQ=; b=uKrPkQ7z//kRJCEDNzlJq3jk9963Z+56kAkAGNixVeitn98yJqkQMIhBYO1kGOdsDG ChwAe9JIO+Y+NVLtWJVhoW37GHQ5l6q7n9Hs15/uIcr0+YY1NhV3cU7rgWfuhjUTHLDP F3kPdaqUAsErGeyoU4v1lN/j9va7VuIJ44dMfTd+0mnRTjHW4xzPYoWJwUMgGkF0JOje yORTgZVVMPOSQeFNwMbzTh7Lu303zxcjjeBLIZLrQBzzlZ/WjxLtyKdSusYE9v+IZDfE KxEkj8zPLAJPsvrgrpuUwkSAwQa4v0VHjEq84bmaS4mtyQypu42ylkQklHjyK5Tu1ZyD nQmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QCo14xV8rAUzfCQotnJU7VU371YftBdUOIgGhDFsTfQ=; b=LVatYOjrGrUKg43fakp5YxH3SqToIBfBP8ytqF+eMrVDDQxr4i8EnWxMfa6i5rxT8d gEeWO5owKN0xQIZ524kY8PFETKPfHFs2GdRaCWxtPrDZMO8YAh0Mlv8Rz8V4hrmdGZJb GMfdO/+tQlaDPHHsfE0w3GLO2evTlwz0iB9GTc+6owj0NherzzVThOK132tH/CZa8sOa 4IxgTH9SNH6GyMSBpZTqXvrb5ro3E73onzDDdqgXWkx5Qn3zwPEyAXJpD97J8S3qZkhW lRaM6leJJHS/BBIUiE6p1rbtpK0cVa9dKaDooGw5Nkml0iLLDZ9z+GLvHuAXj9Qa/GSy QsAw== X-Gm-Message-State: AOAM533FSvvBVAum02z+rV9Wnyr+ipvyKhlSvI71q9n5LVb69CEKUxQe 9MLzovNryh2E1v3KQIHa7+DoNA== X-Google-Smtp-Source: ABdhPJxw9Zesv74cgLZNu9iz4EI0aH/v4a9liAq8BZawNc4Jve8bQGGcctC73X4IMo9Il18j/byJCQ== X-Received: by 2002:a05:6a00:b41:b029:324:2cb7:ed97 with SMTP id p1-20020a056a000b41b02903242cb7ed97mr13631893pfo.53.1625764873255; Thu, 08 Jul 2021 10:21:13 -0700 (PDT) Received: from google.com (150.12.83.34.bc.googleusercontent.com. [34.83.12.150]) by smtp.gmail.com with ESMTPSA id h14sm3833299pgv.47.2021.07.08.10.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 10:21:12 -0700 (PDT) Date: Thu, 8 Jul 2021 10:21:09 -0700 From: Ricardo Koller To: Paolo Bonzini Cc: Jim Mattson , kvm@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "H. Peter Anvin" , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , Nathan Chancellor , Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH 0/5] KVM: x86: Use kernel x86 cpuid utilities in KVM selftests Message-ID: References: <20210422005626.564163-1-ricarkol@google.com> <16823e91-5caf-f52e-e0dc-28ebb9a87b47@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16823e91-5caf-f52e-e0dc-28ebb9a87b47@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 08, 2021 at 06:50:41PM +0200, Paolo Bonzini wrote: > On 29/06/21 19:28, Jim Mattson wrote: > > > Thanks. I was thinking about kvm-unit-tests, but the issue is that it > > > would also be a copy. And just like with kernel headers, it would be > > > ideal to keep them in-sync. The advantage of the kernel headers is that > > > it's much easier to check and fix diffs with them. On the other hand, as > > > you say, there would not be any #ifdef stuff with kvm=unit-tests. Please > > > let me know what you think. > > > > I think the kvm-unit-tests implementation is superior to the kernel > > implementation, but that's probably because I suggested it. Still, I > > think there's an argument to be made that selftests, unlike > > kvm-unit-tests, are part of the kernel distribution and should be > > consistent with the kernel where possible. > > > > Paolo? > > I also prefer the kvm-unit-tests implementation, for what it's worth... > Let's see what the code looks like? I'm not sure I understand the question. You mean: let's see how this looks using kvm-unit-tests headers? If that's the case I can work on a v3 using kvm-unit-tests. Thanks, Ricardo > > Paolo >