All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] contrib: add udev qemu-guest-agent.rules
@ 2021-07-08 15:40 Cole Robinson
  2021-07-08 16:36 ` Daniel P. Berrangé
  0 siblings, 1 reply; 2+ messages in thread
From: Cole Robinson @ 2021-07-08 15:40 UTC (permalink / raw)
  To: qemu-devel; +Cc: Paolo Bonzini, Cole Robinson

Fedora/RHEL and Debian have shipped an identical file for years.
This pairs with contrib/systemd/qemu-guest-agent.service

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 contrib/systemd/qemu-guest-agent.rules | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 contrib/systemd/qemu-guest-agent.rules

diff --git a/contrib/systemd/qemu-guest-agent.rules b/contrib/systemd/qemu-guest-agent.rules
new file mode 100644
index 0000000000..8a290abbd3
--- /dev/null
+++ b/contrib/systemd/qemu-guest-agent.rules
@@ -0,0 +1,2 @@
+SUBSYSTEM=="virtio-ports", ATTR{name}=="org.qemu.guest_agent.0", \
+  TAG+="systemd" ENV{SYSTEMD_WANTS}="qemu-guest-agent.service"
-- 
2.31.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] contrib: add udev qemu-guest-agent.rules
  2021-07-08 15:40 [PATCH] contrib: add udev qemu-guest-agent.rules Cole Robinson
@ 2021-07-08 16:36 ` Daniel P. Berrangé
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2021-07-08 16:36 UTC (permalink / raw)
  To: Cole Robinson; +Cc: Paolo Bonzini, qemu-devel

On Thu, Jul 08, 2021 at 11:40:33AM -0400, Cole Robinson wrote:
> Fedora/RHEL and Debian have shipped an identical file for years.
> This pairs with contrib/systemd/qemu-guest-agent.service
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  contrib/systemd/qemu-guest-agent.rules | 2 ++
>  1 file changed, 2 insertions(+)
>  create mode 100644 contrib/systemd/qemu-guest-agent.rules

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

> diff --git a/contrib/systemd/qemu-guest-agent.rules b/contrib/systemd/qemu-guest-agent.rules
> new file mode 100644
> index 0000000000..8a290abbd3
> --- /dev/null
> +++ b/contrib/systemd/qemu-guest-agent.rules
> @@ -0,0 +1,2 @@
> +SUBSYSTEM=="virtio-ports", ATTR{name}=="org.qemu.guest_agent.0", \
> +  TAG+="systemd" ENV{SYSTEMD_WANTS}="qemu-guest-agent.service"

If you fancy doing more work on top, I'd suggest we wire things
up so that 'make install' will install both this new file and
the .service file, with 'meson' detecting whether we're on a
systemd enabled OS </handwaving> libvirt has some meson rules
you can crib for this purpose.

Not a blocker for merging this particular patch though.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-08 16:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 15:40 [PATCH] contrib: add udev qemu-guest-agent.rules Cole Robinson
2021-07-08 16:36 ` Daniel P. Berrangé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.