From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.0 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F7FC07E96 for ; Thu, 8 Jul 2021 21:14:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DBB860FEB for ; Thu, 8 Jul 2021 21:14:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230238AbhGHVR1 (ORCPT ); Thu, 8 Jul 2021 17:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230442AbhGHVR1 (ORCPT ); Thu, 8 Jul 2021 17:17:27 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3773C06175F for ; Thu, 8 Jul 2021 14:14:43 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id f11so3888195plg.0 for ; Thu, 08 Jul 2021 14:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zmWCdaZ5DtTwEXxtbHEoKMjFOz/dc4W4YTX+9TIJtXQ=; b=H2NtRZXOsJ5SYKLUckMVCIEaBvPxt+dA6L8U35d4W0Tvjz301WrgeL/zxAGix2wnf0 QVN3EKFwGJc5TvQHWeGCu/g0gsLfFf/RARez2GlEfHITr1LCSyhINo7KH/LaiXv0se2B rwW9JqjP1BiagURONrtpjyvxr35de7u0u/WyQD4iKk9JSJgJtBn7e/fXsbhZ6bXGuzyg SW2qbzOTL2N5SsssU4gbn54YGbZEQ3cTAA5mpTwm8v5xEJwZmhHQgs0ux5fd5TmF5S6K 6YCXDNQRvPAV/Tcc5Peaz1dBI6oXm+qmebwohTZRMY/49QLejzzFkv+MX/+XjexGehIM 8bwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zmWCdaZ5DtTwEXxtbHEoKMjFOz/dc4W4YTX+9TIJtXQ=; b=RGx4TzoIrF+5P4QDKni5ioBnUlNQ75K6KGtbg9M0ZxjVwetJAvVkYRGUHTfq+MGuLL 2iMBVcTzYGiCDe8yGdMWKa5ryOLoAQ+TNHSIjih8rznKVm5VyTCvBATmSux4RJxIoZyB W2cSSHAnC+WcaV5hDGRBZAgMSCafPnhPTm5DHZgzKjDYonCnXpiudMXDDxyw9weWTtFi SbY4ZJi4VSVysJGai+0fGhWLdWONAVEZihUXBhXziEcMdEY047nFgqAuhJns5rRHFh+5 +sR2mHwYLu60gUFLHzNzPX9eXBj33RF7iW4+F1xvCXmu9KulFfHcSOKWq3sRlqXOqL+E wYlQ== X-Gm-Message-State: AOAM530sdDcTSj9Og2xMuzNqrmFma6/fsc1BS/ihPPnty6g1kmMZAhb+ B3524V8vkkWNqdl5mlM5mtWgEA== X-Google-Smtp-Source: ABdhPJxWA3xVU4cBNtZZ686VgO3qg1K4LiahKiKJINM4tOadfSoSbrd+rzoIgq17W/N1kET+h8LHHg== X-Received: by 2002:a17:90a:8b0e:: with SMTP id y14mr33662683pjn.191.1625778883113; Thu, 08 Jul 2021 14:14:43 -0700 (PDT) Received: from google.com (254.80.82.34.bc.googleusercontent.com. [34.82.80.254]) by smtp.gmail.com with ESMTPSA id v3sm3746726pfm.198.2021.07.08.14.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 14:14:42 -0700 (PDT) Date: Thu, 8 Jul 2021 21:14:38 +0000 From: David Matlack To: Jing Zhang Cc: KVM , KVMPPC , Paolo Bonzini , Sean Christopherson , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes Subject: Re: [PATCH v1 2/4] KVM: stats: Update doc for histogram statistics Message-ID: References: <20210706180350.2838127-1-jingzhangos@google.com> <20210706180350.2838127-3-jingzhangos@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210706180350.2838127-3-jingzhangos@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jul 06, 2021 at 06:03:48PM +0000, Jing Zhang wrote: > Add documentations for linear and logarithmic histogram statistics. > Add binary stats capability text which is missing during merge of > the binary stats patch. > > Signed-off-by: Jing Zhang > --- > Documentation/virt/kvm/api.rst | 36 +++++++++++++++++++++++++++++++--- > 1 file changed, 33 insertions(+), 3 deletions(-) > > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > index 3b6e3b1628b4..948d33c26704 100644 > --- a/Documentation/virt/kvm/api.rst > +++ b/Documentation/virt/kvm/api.rst > @@ -5171,6 +5171,9 @@ by a string of size ``name_size``. > #define KVM_STATS_TYPE_CUMULATIVE (0x0 << KVM_STATS_TYPE_SHIFT) > #define KVM_STATS_TYPE_INSTANT (0x1 << KVM_STATS_TYPE_SHIFT) > #define KVM_STATS_TYPE_PEAK (0x2 << KVM_STATS_TYPE_SHIFT) > + #define KVM_STATS_TYPE_LINEAR_HIST (0x3 << KVM_STATS_TYPE_SHIFT) > + #define KVM_STATS_TYPE_LOG_HIST (0x4 << KVM_STATS_TYPE_SHIFT) > + #define KVM_STATS_TYPE_MAX KVM_STATS_TYPE_LOG_HIST > > #define KVM_STATS_UNIT_SHIFT 4 > #define KVM_STATS_UNIT_MASK (0xF << KVM_STATS_UNIT_SHIFT) > @@ -5178,11 +5181,13 @@ by a string of size ``name_size``. > #define KVM_STATS_UNIT_BYTES (0x1 << KVM_STATS_UNIT_SHIFT) > #define KVM_STATS_UNIT_SECONDS (0x2 << KVM_STATS_UNIT_SHIFT) > #define KVM_STATS_UNIT_CYCLES (0x3 << KVM_STATS_UNIT_SHIFT) > + #define KVM_STATS_UNIT_MAX KVM_STATS_UNIT_CYCLES > > #define KVM_STATS_BASE_SHIFT 8 > #define KVM_STATS_BASE_MASK (0xF << KVM_STATS_BASE_SHIFT) > #define KVM_STATS_BASE_POW10 (0x0 << KVM_STATS_BASE_SHIFT) > #define KVM_STATS_BASE_POW2 (0x1 << KVM_STATS_BASE_SHIFT) > + #define KVM_STATS_BASE_MAX KVM_STATS_BASE_POW2 Should these FOO_MAX additions go in a separate commit too? > > struct kvm_stats_desc { > __u32 flags; > @@ -5214,6 +5219,22 @@ Bits 0-3 of ``flags`` encode the type: > represents a peak value for a measurement, for example the maximum number > of items in a hash table bucket, the longest time waited and so on. > The corresponding ``size`` field for this type is always 1. > + * ``KVM_STATS_TYPE_LINEAR_HIST`` > + The statistics data is in the form of linear histogram. The number of > + buckets is specified by the ``size`` field. The size of buckets is specified > + by the ``hist_param`` field. The range of the Nth bucket (1 <= N < ``size``) Using 1-based indexes is a little jarring but maybe that's just me :). > + is [``hist_param``*(N-1), ``hist_param``*N), while the range of the last > + bucket is [``hist_param``*(``size``-1), +INF). (+INF means positive infinity > + value.) The bucket value indicates how many times the statistics data is in > + the bucket's range. > + * ``KVM_STATS_TYPE_LOG_HIST`` > + The statistics data is in the form of logarithmic histogram. The number of > + buckets is specified by the ``size`` field. The base of logarithm is > + specified by the ``hist_param`` field. The range of the Nth bucket (1 < N < Should 1 be 2 here? The first bucket uses a slightly differen formula as you mention in the next sentence. Actually it may be clearer if you re-ordered the sentences a bit: The range of the first bucket is [0, 1), while the range of the last bucket is [pow(hist_param, size-1), +INF). Otherwise the Nth bucket (1-indexed) covers [pow(hist_param, N-2), pow(histparam, N-1)). > + ``size``) is [pow(``hist_param``, N-2), pow(``hist_param``, N-1)). The range > + of the first bucket is [0, 1), while the range of the last bucket is > + [pow(``hist_param``, ``size``-2), +INF). The bucket value indicates how many > + times the statistics data is in the bucket's range. > > Bits 4-7 of ``flags`` encode the unit: > * ``KVM_STATS_UNIT_NONE`` > @@ -5246,9 +5267,10 @@ unsigned 64bit data. > The ``offset`` field is the offset from the start of Data Block to the start of > the corresponding statistics data. > > -The ``unused`` field is reserved for future support for other types of > -statistics data, like log/linear histogram. Its value is always 0 for the types > -defined above. > +The ``hist_param`` field is used as a parameter for histogram statistics data. > +For linear histogram statistics data, it indicates the size of a bucket. For > +logarithmic histogram statistics data, it indicates the base of the logarithm. > +Only base of 2 is supported fo logarithmic histogram. s/fo/for/ > > The ``name`` field is the name string of the statistics data. The name string > starts at the end of ``struct kvm_stats_desc``. The maximum length including > @@ -7182,3 +7204,11 @@ The argument to KVM_ENABLE_CAP is also a bitmask, and must be a subset > of the result of KVM_CHECK_EXTENSION. KVM will forward to userspace > the hypercalls whose corresponding bit is in the argument, and return > ENOSYS for the others. > + > +8.35 KVM_CAP_STATS_BINARY_FD > +---------------------------- > + > +:Architectures: all > + > +This capability indicates the feature that userspace can get a file descriptor > +for every VM and VCPU to read statistics data in binary format. > -- > 2.32.0.93.g670b81a890-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Matlack Date: Thu, 08 Jul 2021 21:14:38 +0000 Subject: Re: [PATCH v1 2/4] KVM: stats: Update doc for histogram statistics Message-Id: List-Id: References: <20210706180350.2838127-1-jingzhangos@google.com> <20210706180350.2838127-3-jingzhangos@google.com> In-Reply-To: <20210706180350.2838127-3-jingzhangos@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jing Zhang Cc: KVM , KVMPPC , Paolo Bonzini , Sean Christopherson , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes On Tue, Jul 06, 2021 at 06:03:48PM +0000, Jing Zhang wrote: > Add documentations for linear and logarithmic histogram statistics. > Add binary stats capability text which is missing during merge of > the binary stats patch. > > Signed-off-by: Jing Zhang > --- > Documentation/virt/kvm/api.rst | 36 +++++++++++++++++++++++++++++++--- > 1 file changed, 33 insertions(+), 3 deletions(-) > > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > index 3b6e3b1628b4..948d33c26704 100644 > --- a/Documentation/virt/kvm/api.rst > +++ b/Documentation/virt/kvm/api.rst > @@ -5171,6 +5171,9 @@ by a string of size ``name_size``. > #define KVM_STATS_TYPE_CUMULATIVE (0x0 << KVM_STATS_TYPE_SHIFT) > #define KVM_STATS_TYPE_INSTANT (0x1 << KVM_STATS_TYPE_SHIFT) > #define KVM_STATS_TYPE_PEAK (0x2 << KVM_STATS_TYPE_SHIFT) > + #define KVM_STATS_TYPE_LINEAR_HIST (0x3 << KVM_STATS_TYPE_SHIFT) > + #define KVM_STATS_TYPE_LOG_HIST (0x4 << KVM_STATS_TYPE_SHIFT) > + #define KVM_STATS_TYPE_MAX KVM_STATS_TYPE_LOG_HIST > > #define KVM_STATS_UNIT_SHIFT 4 > #define KVM_STATS_UNIT_MASK (0xF << KVM_STATS_UNIT_SHIFT) > @@ -5178,11 +5181,13 @@ by a string of size ``name_size``. > #define KVM_STATS_UNIT_BYTES (0x1 << KVM_STATS_UNIT_SHIFT) > #define KVM_STATS_UNIT_SECONDS (0x2 << KVM_STATS_UNIT_SHIFT) > #define KVM_STATS_UNIT_CYCLES (0x3 << KVM_STATS_UNIT_SHIFT) > + #define KVM_STATS_UNIT_MAX KVM_STATS_UNIT_CYCLES > > #define KVM_STATS_BASE_SHIFT 8 > #define KVM_STATS_BASE_MASK (0xF << KVM_STATS_BASE_SHIFT) > #define KVM_STATS_BASE_POW10 (0x0 << KVM_STATS_BASE_SHIFT) > #define KVM_STATS_BASE_POW2 (0x1 << KVM_STATS_BASE_SHIFT) > + #define KVM_STATS_BASE_MAX KVM_STATS_BASE_POW2 Should these FOO_MAX additions go in a separate commit too? > > struct kvm_stats_desc { > __u32 flags; > @@ -5214,6 +5219,22 @@ Bits 0-3 of ``flags`` encode the type: > represents a peak value for a measurement, for example the maximum number > of items in a hash table bucket, the longest time waited and so on. > The corresponding ``size`` field for this type is always 1. > + * ``KVM_STATS_TYPE_LINEAR_HIST`` > + The statistics data is in the form of linear histogram. The number of > + buckets is specified by the ``size`` field. The size of buckets is specified > + by the ``hist_param`` field. The range of the Nth bucket (1 <= N < ``size``) Using 1-based indexes is a little jarring but maybe that's just me :). > + is [``hist_param``*(N-1), ``hist_param``*N), while the range of the last > + bucket is [``hist_param``*(``size``-1), +INF). (+INF means positive infinity > + value.) The bucket value indicates how many times the statistics data is in > + the bucket's range. > + * ``KVM_STATS_TYPE_LOG_HIST`` > + The statistics data is in the form of logarithmic histogram. The number of > + buckets is specified by the ``size`` field. The base of logarithm is > + specified by the ``hist_param`` field. The range of the Nth bucket (1 < N < Should 1 be 2 here? The first bucket uses a slightly differen formula as you mention in the next sentence. Actually it may be clearer if you re-ordered the sentences a bit: The range of the first bucket is [0, 1), while the range of the last bucket is [pow(hist_param, size-1), +INF). Otherwise the Nth bucket (1-indexed) covers [pow(hist_param, N-2), pow(histparam, N-1)). > + ``size``) is [pow(``hist_param``, N-2), pow(``hist_param``, N-1)). The range > + of the first bucket is [0, 1), while the range of the last bucket is > + [pow(``hist_param``, ``size``-2), +INF). The bucket value indicates how many > + times the statistics data is in the bucket's range. > > Bits 4-7 of ``flags`` encode the unit: > * ``KVM_STATS_UNIT_NONE`` > @@ -5246,9 +5267,10 @@ unsigned 64bit data. > The ``offset`` field is the offset from the start of Data Block to the start of > the corresponding statistics data. > > -The ``unused`` field is reserved for future support for other types of > -statistics data, like log/linear histogram. Its value is always 0 for the types > -defined above. > +The ``hist_param`` field is used as a parameter for histogram statistics data. > +For linear histogram statistics data, it indicates the size of a bucket. For > +logarithmic histogram statistics data, it indicates the base of the logarithm. > +Only base of 2 is supported fo logarithmic histogram. s/fo/for/ > > The ``name`` field is the name string of the statistics data. The name string > starts at the end of ``struct kvm_stats_desc``. The maximum length including > @@ -7182,3 +7204,11 @@ The argument to KVM_ENABLE_CAP is also a bitmask, and must be a subset > of the result of KVM_CHECK_EXTENSION. KVM will forward to userspace > the hypercalls whose corresponding bit is in the argument, and return > ENOSYS for the others. > + > +8.35 KVM_CAP_STATS_BINARY_FD > +---------------------------- > + > +:Architectures: all > + > +This capability indicates the feature that userspace can get a file descriptor > +for every VM and VCPU to read statistics data in binary format. > -- > 2.32.0.93.g670b81a890-goog >