From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82FB9C07E9B for ; Fri, 9 Jul 2021 09:49:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64DC86135C for ; Fri, 9 Jul 2021 09:49:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232007AbhGIJwP (ORCPT ); Fri, 9 Jul 2021 05:52:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:34250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhGIJwO (ORCPT ); Fri, 9 Jul 2021 05:52:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8D082613C9; Fri, 9 Jul 2021 09:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1625824171; bh=YZwPUM0lSWCTbis2MmjpX1SiDovOw/fIlz9+8wFkuu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jh2j6/HywdOkvOKergRftBGHQA3Lz6fGFjar+rpj+IOL/tyjsk45725s2q1qufIsR AmA3llgBmUWdrv4Y5Mwml4SLarVlxcXhnxDaJn27/aVfq6JmSMt8nDkixK5773Yr1n B2yR2t3BOK2LKpgqbbYR04vr1Bdx1uDwqqBefYuY= Date: Fri, 9 Jul 2021 11:49:27 +0200 From: Greg KH To: Nava kishore Manne Cc: "robh+dt@kernel.org" , Michal Simek , "mdf@kernel.org" , "trix@redhat.com" , "arnd@arndb.de" , Rajan Vaja , Amit Sunil Dhamne , Tejas Patel , "zou_wei@huawei.com" , Sai Krishna Potthuri , Ravi Patel , "iwamatsu@nigauri.org" , Jiaying Liang , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-fpga@vger.kernel.org" , git , "chinnikishore369@gmail.com" Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API support Message-ID: References: <20210609055232.4501-1-nava.manne@xilinx.com> <20210609055232.4501-2-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 09, 2021 at 08:41:35AM +0000, Nava kishore Manne wrote: > Hi Greg, > > Thanks for providing the review comments. > Please find my response inline. > > > -----Original Message----- > > From: Greg KH > > Sent: Wednesday, June 9, 2021 3:25 PM > > To: Nava kishore Manne > > Cc: robh+dt@kernel.org; Michal Simek ; > > mdf@kernel.org; trix@redhat.com; arnd@arndb.de; Rajan Vaja > > ; Amit Sunil Dhamne ; > > Tejas Patel ; zou_wei@huawei.com; Sai Krishna > > Potthuri ; Ravi Patel ; > > iwamatsu@nigauri.org; Jiaying Liang ; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; linux-fpga@vger.kernel.org; git ; > > chinnikishore369@gmail.com > > Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API > > support > > > > On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote: > > > This patch adds user encrypted key load API to support User key > > > encrypted images loading use cases from Linux. > > > > What is "user key encrypted images"? Do we need more documentation > > here for what this is and how to use it? > > > > Xilinx bitstream writer, using AES, encrypts the bitstream. This feature allows user to encrypt bitstream using 256-bit AES encryption in cipher block chaining (CBC) mode. > User can supply a 128-bit Initial Vector and 256-bit key(user key). Please provide the needed information in the changelog comment. > For more info please refer here: > https://www.xilinx.com/support/documentation/application_notes/xapp1239-fpga-bitstream-encryption.pdf External links always grow stale. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32C3C07E9B for ; Fri, 9 Jul 2021 09:51:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A64B9613C9 for ; Fri, 9 Jul 2021 09:51:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A64B9613C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XlKA2hQK4m+uTTFXT2eY3HN0WK0Qw5bzZaSRm/MlLzo=; b=EfHausXbohITYe Iho0PdRq0FzR+oerStmy/SkGyDMgIJbvDa6ce7OBXay/YKsJRzz+dVlsxLy6Zglmd7suSZTDn2gEw px37fX0mVZJ0D+7alH1wOHerwtevz50cNbcBrI7Ciwfnx0SO7D2gYmaLedSQnWqDqewtGWjuH06ix nc2BWCd6UcumKrzl0c3wwyPSraGCHAf07jZlWSbHBQM3GzfxzQEirnExI41of45WRCkjEeS4L70ia 02HwV3qilT5tgHOt8k68qCsdZjnTvzGz/27rsOiT5/ckWgN/Jfp59AqRukHWl9Kx0aAkpCRrTbhHw BgBcucQdcQ2ubVdI7uSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1n8Y-001Oro-WF; Fri, 09 Jul 2021 09:49:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m1n8V-001OrA-Gz for linux-arm-kernel@lists.infradead.org; Fri, 09 Jul 2021 09:49:33 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8D082613C9; Fri, 9 Jul 2021 09:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1625824171; bh=YZwPUM0lSWCTbis2MmjpX1SiDovOw/fIlz9+8wFkuu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jh2j6/HywdOkvOKergRftBGHQA3Lz6fGFjar+rpj+IOL/tyjsk45725s2q1qufIsR AmA3llgBmUWdrv4Y5Mwml4SLarVlxcXhnxDaJn27/aVfq6JmSMt8nDkixK5773Yr1n B2yR2t3BOK2LKpgqbbYR04vr1Bdx1uDwqqBefYuY= Date: Fri, 9 Jul 2021 11:49:27 +0200 From: Greg KH To: Nava kishore Manne Cc: "robh+dt@kernel.org" , Michal Simek , "mdf@kernel.org" , "trix@redhat.com" , "arnd@arndb.de" , Rajan Vaja , Amit Sunil Dhamne , Tejas Patel , "zou_wei@huawei.com" , Sai Krishna Potthuri , Ravi Patel , "iwamatsu@nigauri.org" , Jiaying Liang , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-fpga@vger.kernel.org" , git , "chinnikishore369@gmail.com" Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API support Message-ID: References: <20210609055232.4501-1-nava.manne@xilinx.com> <20210609055232.4501-2-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210709_024931_631594_0E1D4BEF X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 09, 2021 at 08:41:35AM +0000, Nava kishore Manne wrote: > Hi Greg, > > Thanks for providing the review comments. > Please find my response inline. > > > -----Original Message----- > > From: Greg KH > > Sent: Wednesday, June 9, 2021 3:25 PM > > To: Nava kishore Manne > > Cc: robh+dt@kernel.org; Michal Simek ; > > mdf@kernel.org; trix@redhat.com; arnd@arndb.de; Rajan Vaja > > ; Amit Sunil Dhamne ; > > Tejas Patel ; zou_wei@huawei.com; Sai Krishna > > Potthuri ; Ravi Patel ; > > iwamatsu@nigauri.org; Jiaying Liang ; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; linux-fpga@vger.kernel.org; git ; > > chinnikishore369@gmail.com > > Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API > > support > > > > On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote: > > > This patch adds user encrypted key load API to support User key > > > encrypted images loading use cases from Linux. > > > > What is "user key encrypted images"? Do we need more documentation > > here for what this is and how to use it? > > > > Xilinx bitstream writer, using AES, encrypts the bitstream. This feature allows user to encrypt bitstream using 256-bit AES encryption in cipher block chaining (CBC) mode. > User can supply a 128-bit Initial Vector and 256-bit key(user key). Please provide the needed information in the changelog comment. > For more info please refer here: > https://www.xilinx.com/support/documentation/application_notes/xapp1239-fpga-bitstream-encryption.pdf External links always grow stale. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel