From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Saravana Kannan <saravanak@google.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org, Avri Altman <avri.altman@wdc.com>,
Bean Huo <huobean@gmail.com>, Can Guo <cang@codeaurora.org>,
Asutosh Das <asutoshd@codeaurora.org>,
Bart Van Assche <bvanassche@acm.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] driver core: Add ability to delete device links of unregistered devices
Date: Fri, 9 Jul 2021 11:55:16 +0200 [thread overview]
Message-ID: <YOgdBGBEYNndLLwa@kroah.com> (raw)
In-Reply-To: <20210709064341.6206-2-adrian.hunter@intel.com>
On Fri, Jul 09, 2021 at 09:43:40AM +0300, Adrian Hunter wrote:
> Managed device links are deleted by device_del(). However it is possible to
> add a device link to a consumer before device_add(), and then discover an
> error prevents the device from being used. In that case normally references
> to the device would be dropped and the device would be deleted. However the
> device link holds a reference to the device, so the device link and device
> remain indefinitely.
Why are you not just manually removing the link you just created? You
manually added it, you know something failed so you need to clean up, so
why not clean this up too?
thanks,
greg k-h
next prev parent reply other threads:[~2021-07-09 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 6:43 [PATCH V2 0/2] driver core: Add ability to delete device links of unregistered devices Adrian Hunter
2021-07-09 6:43 ` [PATCH V2 1/2] " Adrian Hunter
2021-07-09 9:55 ` Greg Kroah-Hartman [this message]
2021-07-09 11:19 ` Rafael J. Wysocki
2021-07-09 11:28 ` Rafael J. Wysocki
2021-07-09 13:18 ` Adrian Hunter
2021-07-09 6:43 ` [PATCH V2 2/2] scsi: ufshcd: Fix device links when BOOT WLUN fails to probe Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOgdBGBEYNndLLwa@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.