Re: [PATCH 2/2] oslat: Add trace maker prior starting main thread

From: Peter Xu <peterx@redhat.com>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc: linux-rt-users@vger.kernel.org, williams@redhat.com, jkacur@redhat.com
Subject: Re: [PATCH 2/2] oslat: Add trace maker prior starting main thread
Date: Fri, 9 Jul 2021 14:39:54 -0400	[thread overview]
Message-ID: <YOiX+lp/PQL136TZ@t490s> (raw)
In-Reply-To: <20210709155414.610308-2-nsaenzju@redhat.com>

On Fri, Jul 09, 2021 at 05:54:14PM +0200, Nicolas Saenz Julienne wrote:
> After a long tracing session it's sometimes hard to find the moment
> oslat started. So leave a message in the trace buffer just before the
> main thread starts.
> 
> Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
> ---
>  src/oslat/oslat.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
> index d35be57..20bf02b 100644
> --- a/src/oslat/oslat.c
> +++ b/src/oslat/oslat.c
> @@ -400,6 +400,10 @@ static void *thread_main(void *arg)
>  	while (g.n_threads_running != g.n_threads)
>  		relax();
>  
> +	if (!g.preheat)
> +		tracemark(false, "%s: Starting thread on CPU %d.\n",
> +			  g.app_name, t->core_i);
> +
>  	frc(&t->frc_start);
>  	doit(t);
>  	frc(&t->frc_stop);
> -- 
> 2.31.1
> 

Not sure how it would help.. but no objection either. :)

Acked-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu