All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] tst_net.sh: Declare prefix variable as empty
Date: Mon, 12 Jul 2021 07:49:50 +0200	[thread overview]
Message-ID: <YOvX/tczl7Duu+6L@pevik> (raw)
In-Reply-To: <CAEemH2fB5VakafKhTgcOsvwK6Q50AJ3WcpRY2fSLfhB86b03Nw@mail.gmail.com>

Hi Li,
> On Fri, Jul 9, 2021 at 10:01 PM Petr Vorel <pvorel@suse.cz> wrote:

> > From: Petr Vorel <petr.vorel@gmail.com>

> > in tst_ipaddr_un(). This is required to fix problem on dash, which
> > (unlike bash and busybox ash implementation) takes value of previously
> > defined variable, i.e.  guarding with local does not work:

> > $ foo=ee; bar() { local foo; echo "foo: '$foo'"; }; bar
> > foo: 'ee'


> I'm thinking maybe we should avoid defining the same name
> variables like that. But anyway, your fix should be worked.

> Reviewed-by: Li Wang <liwang@redhat.com>

Thanks for a review!
It's a bit strange to add '=' only single variable, maybe I should have rename
the variable.

Paranoid approach would be to add '=' to any variable which is assigned only on
some circumstance or even any variable which is not assigned to any value.
But we probably don't want to do it.

Kind regards,
Petr

  reply	other threads:[~2021-07-12  5:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09 14:01 [LTP] [PATCH 1/1] tst_net.sh: Declare prefix variable as empty Petr Vorel
2021-07-12  2:00 ` Li Wang
2021-07-12  5:49   ` Petr Vorel [this message]
2021-07-12  5:57     ` Joerg Vehlow
2021-07-12  6:40       ` Petr Vorel
2021-07-12 16:12       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YOvX/tczl7Duu+6L@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.