From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E13C07E99 for ; Mon, 12 Jul 2021 11:03:17 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C94016054E for ; Mon, 12 Jul 2021 11:03:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C94016054E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.154508.285498 (Exim 4.92) (envelope-from ) id 1m2tiM-0008EN-3c; Mon, 12 Jul 2021 11:03:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154508.285498; Mon, 12 Jul 2021 11:03:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m2tiL-0008EG-Vy; Mon, 12 Jul 2021 11:03:05 +0000 Received: by outflank-mailman (input) for mailman id 154508; Mon, 12 Jul 2021 11:03:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m2tiK-0008EA-Uf for xen-devel@lists.xenproject.org; Mon, 12 Jul 2021 11:03:04 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 13b568aa-27b3-4e24-87ec-f93db7e88299; Mon, 12 Jul 2021 11:03:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13b568aa-27b3-4e24-87ec-f93db7e88299 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626087783; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MDGf0GOT8MKEQ9BoxBwjqpUYukrI9cs/XR0ewV3rjgI=; b=BpfE7znsJvCL0YP5zQSoitxvP2Upv2s+/J2b8cdxWR+jn9L0MVhOhcsY Br+AO/pBKz9vuuQbRgILa0gNo6PDUSDGCvpBsXp5YQ7f8a/OqxN50NYkq d/Us7CB1hm9IqAhfOdoOkoHlJthxQUrafHhamjUOKWqv8i5H+uNuOIVhn 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: +ZWWVgX8WxgtVXVnKsD9iejoiHigL0gY+lVoXiPUv4Ozx65KWKJnOMqtBahhaBeoQNftFQhp1T ThjZr/uiEWIsynxXFrxcyPixhlDlns7YEk4xnwglCugV42heexDBnPNoLjFShCHz9j+k52irBm H46p39zRLMtsdcw9n5paZp4UNaCHbueGmgh+ga66QkpZpyk7FNJLMuEHihwDyOu9VBKKlCqhv9 hlOJ4iTjtHwsepTAb7XHfsalurXhCa2bwlxxtQ9PBXCxV/ofcRxw6afcLTQufr+yhCB31BiSNL 9Xc= X-SBRS: 5.1 X-MesageID: 48113017 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:B/pCia880OhYKgafUnpuk+DaI+orL9Y04lQ7vn2YSXRuE/Bws/ re+8jztCWE7Ar5N0tNpTntAsa9qDbnhPhICOoqTNKftWvdyQiVxehZhOOIqVDd8m/Fh4xgPM 9bAtFD4bbLbWSS4/yV3DWF X-IronPort-AV: E=Sophos;i="5.84,232,1620705600"; d="scan'208";a="48113017" Date: Mon, 12 Jul 2021 12:02:59 +0100 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Subject: Re: [XEN PATCH v6 05/31] build: factorise generation of the linker scripts Message-ID: References: <20210701141011.785641-1-anthony.perard@citrix.com> <20210701141011.785641-6-anthony.perard@citrix.com> <5a9f0468-7ef6-eebb-cebc-492050ed7e8f@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5a9f0468-7ef6-eebb-cebc-492050ed7e8f@suse.com> On Wed, Jul 07, 2021 at 04:25:33PM +0200, Jan Beulich wrote: > On 01.07.2021 16:09, Anthony PERARD wrote: > > In Arm and X86 makefile, generating the linker script is the same, so > > we can simply have both call the same macro. > > > > We need to add *.lds files into extra-y so that Rules.mk can find the > > .*.cmd dependency file and load it. > > > > Change made to the command line: > > - Use cpp_flags macro which simply filter -Wa,% options from $(a_flags). > > - Added -D__LINKER__ even it is only used by Arm's lds. > > I'm not really happy about this, not the least because the symbol's name > doesn't fit its purpose (we're not linking, but producing a linker script > at that stage), but well ... Also, the leading "__" is probably a bad idea as I think it's reserved? I'll look at adding creating a patch which would rename that to LINKER_SCRIPT which seems more appropriate. > > Signed-off-by: Anthony PERARD > > Reviewed-by: Jan Beulich Thanks, -- Anthony PERARD