From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BEB0C07E9A for ; Mon, 12 Jul 2021 14:54:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA14561167 for ; Mon, 12 Jul 2021 14:54:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA14561167 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.154593.285628 (Exim 4.92) (envelope-from ) id 1m2xK8-0001lS-2Y; Mon, 12 Jul 2021 14:54:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 154593.285628; Mon, 12 Jul 2021 14:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m2xK7-0001lL-VZ; Mon, 12 Jul 2021 14:54:19 +0000 Received: by outflank-mailman (input) for mailman id 154593; Mon, 12 Jul 2021 14:54:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m2xK7-0001lF-EG for xen-devel@lists.xenproject.org; Mon, 12 Jul 2021 14:54:19 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 08401b6e-e321-11eb-86ef-12813bfff9fa; Mon, 12 Jul 2021 14:54:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08401b6e-e321-11eb-86ef-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626101657; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mlp4vXboFWNjT2ndWvNd8eo+Kao87TBHZbzIe22ZgyM=; b=LTgo4HQKRNW4H/45+PQT+W+vBAh6VOztLEBTk+6Sv37eabUc1n0gI77/ wzn3qtqmzDx9143poXpKNKTG8bzS4Kjk9cime7RCCJIx1AH/UuYmZ4Khp uJOpIlz02gMjgKZdPjXZOZHkrxqu/REkNoBDTd9hCfarfZZbja4jch9Q4 g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: JPB299ONwkUGzCZHFfcalILyp5qTFYkS6lFBvF5YknLdZuFQVr86u+fydN373RQu/gdXrMXd9c HTrAiKKLGq4RLi2mfJRj8vTjFmZl0gT59RJ7kTItM6nE99wOEvLfnbKPmBKKMivCFusw+Dharj rThOX5JG1lILA7A7RnrhS75FzJfrkKz5BEcgAhF/5A4S+VfRZJuOntVJRFstvW7QJ01vLooZmQ g7E6ZiumAWq5wOdsdatkYfAeMUF+UuHyLvVd3k/3vl2KBbbJKsxnhl3180DXbyNJLWQvGhCuGQ xG4= X-SBRS: 5.1 X-MesageID: 47773444 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:BcS2Y6Oi7cX4A8BcTsOjsMiBIKoaSvp037Eqv3oRdfVwSL3+qy nOpoV+6faaslossR0b9uxofZPwJ080lqQFhLX5X43SPzUO0VHAROoJgLcKgQeQeREWntQtrJ uIGJIfNDSfNzZHsfo= X-IronPort-AV: E=Sophos;i="5.84,234,1620705600"; d="scan'208";a="47773444" Date: Mon, 12 Jul 2021 15:54:14 +0100 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Subject: Re: [XEN PATCH v6 11/31] build: fix clean targets when subdir-y is used Message-ID: References: <20210701141011.785641-1-anthony.perard@citrix.com> <20210701141011.785641-12-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Jul 07, 2021 at 05:15:44PM +0200, Jan Beulich wrote: > On 01.07.2021 16:09, Anthony PERARD wrote: > > The make variable $(subdir-y) isn't used yet but will be in a > > following patch. Anything in $(subdir-y) doesn't to have a '/' as > > suffix as we already now it's a directory. > > > > Rework the rules so that it doesn't matter whether there is a '/' or > > not. It also mimic more closely to the way Linux's Kbuild descend in > > subdirectories. > > > > FORCE phony target isn't needed anymore running clean, so it can be > > removed. > > > > Signed-off-by: Anthony PERARD > > Reviewed-by: Jan Beulich Thanks. > > --- a/xen/scripts/Makefile.clean > > +++ b/xen/scripts/Makefile.clean > > @@ -12,19 +12,18 @@ include Makefile > > # Figure out what we need to clean from the various variables > > # ========================================================================== > > subdir-all := $(subdir-y) $(subdir-n) $(subdir-) \ > > - $(filter %/, $(obj-y) $(obj-n) $(obj-)) > > + $(patsubst %/,%, $(filter %/, $(obj-y) $(obj-n) $(obj-))) > > Isn't this a normalization which also wants doing in xen/Rules.mk for > subdir-y? Or perhaps this is part of one of the subsequent patches > already? Indeed, a similar change is done as part of build: build everything from the root dir, use obj=$subdir Cheers, -- Anthony PERARD