From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D0DC4338F for ; Sun, 25 Jul 2021 10:10:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5C6D60E73 for ; Sun, 25 Jul 2021 10:10:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230495AbhGYJaX (ORCPT ); Sun, 25 Jul 2021 05:30:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:33606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230479AbhGYJaW (ORCPT ); Sun, 25 Jul 2021 05:30:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F66E60725; Sun, 25 Jul 2021 10:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627207853; bh=DznZekU7W96nK7tplZoslie8uQH/QAkxMN261QPwAYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mYGfqzL32v2bRWmKFTdU0Q+zLx90XcgKQDKkXofc/bdyU2bi8yeLbRQTfPzxo5gnN negOoqMVgcV9ryTmiNn0qSaGlpDPtiS9HD9xXkFcI55lBY5fBp+fz8cmcV44lcQ2+f JrgLF3qSyLjU4GHqqZNeNKOdZ8dWBab2f4WvWnYFlwdT80Co0WF5pyQ4sHvLJURZMj 4/gbcZt7hFt2qUoWXoWUN5yynW5krPxef+zuTHNzebIvGjkAprzjpGUVd5JYffaJMq tK5PCyJDjjo0g/PgoUFt+BNoDFxUaGT1l76eyAZFg08wWChexD16Ang2O1DObw3649 J4TzhnKUPN6wg== Date: Sun, 25 Jul 2021 13:10:49 +0300 From: Leon Romanovsky To: Jiapeng Chong Cc: saeedm@nvidia.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net/mlx5: Fix missing return value in mlx5_devlink_eswitch_inline_mode_set() Message-ID: References: <1626947897-73558-1-git-send-email-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1626947897-73558-1-git-send-email-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Jul 22, 2021 at 05:58:16PM +0800, Jiapeng Chong wrote: > The return value is missing in this code scenario, add the return value > '0' to the return value 'err'. > > Eliminate the follow smatch warning: > > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c:3083 > mlx5_devlink_eswitch_inline_mode_set() warn: missing error code 'err'. > > Reported-by: Abaci Robot > Fixes: 8e0aa4bc959c ("net/mlx5: E-switch, Protect eswitch mode changes") > Signed-off-by: Jiapeng Chong > --- > Changes in v2: > -For the follow advice: https://lore.kernel.org/patchwork/patch/1461601/ > > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky