All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Inki Dae <inki.dae@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Marek Vasut <marex@denx.de>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 05/17] drm/exynos: dsi: Get the mode from bridge
Date: Sun, 25 Jul 2021 19:17:47 +0200	[thread overview]
Message-ID: <YP2cuisYfklwTUth@ravnborg.org> (raw)
In-Reply-To: <20210704090230.26489-6-jagan@amarulasolutions.com>

Hi Jagan,

On Sun, Jul 04, 2021 at 02:32:18PM +0530, Jagan Teki wrote:
> Now the exynos dsi driver is fully aware of bridge
> handling, so get the display mode from bridge, mode_set
> API instead of legacy encoder crtc.
> 
> This makes bridge usage more efficient instead of relying
> on encoder stack.
> 
> Add mode_set in drm_bridge_funcs.

Based on your description I had expected to find get_modes implmneted
and the flag DRM_BRIDGE_OP_MODES set.

	Sam

> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index d828be07c325..99a1b8c22313 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -275,6 +275,7 @@ struct exynos_dsi {
>  	u32 format;
>  
>  	int state;
> +	struct drm_display_mode mode;
>  	struct drm_property *brightness;
>  	struct completion completed;
>  
> @@ -881,7 +882,7 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi)
>  
>  static void exynos_dsi_set_display_mode(struct exynos_dsi *dsi)
>  {
> -	struct drm_display_mode *m = &dsi->encoder.crtc->state->adjusted_mode;
> +	struct drm_display_mode *m = &dsi->mode;
>  	unsigned int num_bits_resol = dsi->driver_data->num_bits_resol;
>  	u32 reg;
>  
> @@ -1411,6 +1412,15 @@ static void exynos_dsi_bridge_disable(struct drm_bridge *bridge)
>  	pm_runtime_put_sync(dsi->dev);
>  }
>  
> +static void exynos_dsi_bridge_mode_set(struct drm_bridge *bridge,
> +				       const struct drm_display_mode *mode,
> +				       const struct drm_display_mode *adjusted_mode)
> +{
> +	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
> +
> +	drm_mode_copy(&dsi->mode, adjusted_mode);
> +}
> +
>  static int exynos_dsi_panel_or_bridge(struct exynos_dsi *dsi,
>  				      struct device_node *node)
>  {
> @@ -1451,6 +1461,7 @@ static int exynos_dsi_bridge_attach(struct drm_bridge *bridge,
>  static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = {
>  	.enable = exynos_dsi_bridge_enable,
>  	.disable = exynos_dsi_bridge_disable,
> +	.mode_set = exynos_dsi_bridge_mode_set,
>  	.attach = exynos_dsi_bridge_attach,
>  };
>  
> -- 
> 2.25.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Marek Vasut <marex@denx.de>,
	devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	dri-devel@lists.freedesktop.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Robert Foss <robert.foss@linaro.org>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	NXP Linux Team <linux-imx@nxp.com>
Subject: Re: [RFC PATCH 05/17] drm/exynos: dsi: Get the mode from bridge
Date: Sun, 25 Jul 2021 19:17:47 +0200	[thread overview]
Message-ID: <YP2cuisYfklwTUth@ravnborg.org> (raw)
In-Reply-To: <20210704090230.26489-6-jagan@amarulasolutions.com>

Hi Jagan,

On Sun, Jul 04, 2021 at 02:32:18PM +0530, Jagan Teki wrote:
> Now the exynos dsi driver is fully aware of bridge
> handling, so get the display mode from bridge, mode_set
> API instead of legacy encoder crtc.
> 
> This makes bridge usage more efficient instead of relying
> on encoder stack.
> 
> Add mode_set in drm_bridge_funcs.

Based on your description I had expected to find get_modes implmneted
and the flag DRM_BRIDGE_OP_MODES set.

	Sam

> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index d828be07c325..99a1b8c22313 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -275,6 +275,7 @@ struct exynos_dsi {
>  	u32 format;
>  
>  	int state;
> +	struct drm_display_mode mode;
>  	struct drm_property *brightness;
>  	struct completion completed;
>  
> @@ -881,7 +882,7 @@ static int exynos_dsi_init_link(struct exynos_dsi *dsi)
>  
>  static void exynos_dsi_set_display_mode(struct exynos_dsi *dsi)
>  {
> -	struct drm_display_mode *m = &dsi->encoder.crtc->state->adjusted_mode;
> +	struct drm_display_mode *m = &dsi->mode;
>  	unsigned int num_bits_resol = dsi->driver_data->num_bits_resol;
>  	u32 reg;
>  
> @@ -1411,6 +1412,15 @@ static void exynos_dsi_bridge_disable(struct drm_bridge *bridge)
>  	pm_runtime_put_sync(dsi->dev);
>  }
>  
> +static void exynos_dsi_bridge_mode_set(struct drm_bridge *bridge,
> +				       const struct drm_display_mode *mode,
> +				       const struct drm_display_mode *adjusted_mode)
> +{
> +	struct exynos_dsi *dsi = bridge_to_dsi(bridge);
> +
> +	drm_mode_copy(&dsi->mode, adjusted_mode);
> +}
> +
>  static int exynos_dsi_panel_or_bridge(struct exynos_dsi *dsi,
>  				      struct device_node *node)
>  {
> @@ -1451,6 +1461,7 @@ static int exynos_dsi_bridge_attach(struct drm_bridge *bridge,
>  static const struct drm_bridge_funcs exynos_dsi_bridge_funcs = {
>  	.enable = exynos_dsi_bridge_enable,
>  	.disable = exynos_dsi_bridge_disable,
> +	.mode_set = exynos_dsi_bridge_mode_set,
>  	.attach = exynos_dsi_bridge_attach,
>  };
>  
> -- 
> 2.25.1

  reply	other threads:[~2021-07-25 17:19 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-04  9:02 [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge Jagan Teki
2021-07-04  9:02 ` Jagan Teki
2021-07-04  9:02 ` Jagan Teki
2021-07-04  9:02 ` [RFC PATCH 01/17] drm/exynos: dsi: Convert to bridge driver Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-25 17:08   ` Sam Ravnborg
2021-07-25 17:08     ` Sam Ravnborg
2021-07-04  9:02 ` [RFC PATCH 02/17] drm/exynos: dsi: Handle drm_device for bridge Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-25 17:09   ` Sam Ravnborg
2021-07-25 17:09     ` Sam Ravnborg
2021-07-04  9:02 ` [RFC PATCH 03/17] drm/exynos: dsi: Use the drm_panel_bridge API Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-05 11:47   ` Marek Szyprowski
2021-07-05 11:47     ` Marek Szyprowski
2021-07-05 11:47     ` Marek Szyprowski
2021-07-05 12:00     ` Jagan Teki
2021-07-05 12:00       ` Jagan Teki
2021-07-05 12:00       ` Jagan Teki
2021-07-05 12:13       ` Marek Szyprowski
2021-07-05 12:13         ` Marek Szyprowski
2021-07-05 12:13         ` Marek Szyprowski
2021-07-05 12:34         ` Jagan Teki
2021-07-05 12:34           ` Jagan Teki
2021-07-05 12:34           ` Jagan Teki
2021-07-04  9:02 ` [RFC PATCH 04/17] drm/exynos: dsi: Create bridge connector for encoder Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02 ` [RFC PATCH 05/17] drm/exynos: dsi: Get the mode from bridge Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-25 17:17   ` Sam Ravnborg [this message]
2021-07-25 17:17     ` Sam Ravnborg
2021-07-29 13:20   ` Robert Foss
2021-07-29 13:20     ` Robert Foss
2021-07-29 13:20     ` Robert Foss
2021-07-29 16:50     ` Sam Ravnborg
2021-07-29 16:50       ` Sam Ravnborg
2021-07-04  9:02 ` [RFC PATCH 06/17] drm/exynos: dsi: Handle exynos specifics via driver_data Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-25 17:25   ` Sam Ravnborg
2021-07-25 17:25     ` Sam Ravnborg
2021-07-25 17:31     ` Jagan Teki
2021-07-25 17:31       ` Jagan Teki
2021-07-25 17:31       ` Jagan Teki
2021-08-13  6:50     ` Inki Dae
2021-08-13  6:50       ` Inki Dae
2021-08-13 12:16       ` Laurent Pinchart
2021-08-13 12:16         ` Laurent Pinchart
2021-08-18  6:09         ` Inki Dae
2021-08-18  6:09           ` Inki Dae
2021-07-04  9:02 ` [RFC PATCH 07/17] drm: bridge: Move exynos_drm_dsi into bridges Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04 13:26   ` kernel test robot
2021-07-04  9:02 ` [RFC PATCH 08/17] dt-bindings: display: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-12 15:13   ` Rob Herring
2021-07-12 15:13     ` Rob Herring
2021-07-12 15:13     ` Rob Herring
2021-07-12 15:23     ` Jagan Teki
2021-07-12 15:23       ` Jagan Teki
2021-07-12 15:23       ` Jagan Teki
2021-07-04  9:02 ` [RFC PATCH 09/17] drm: bridge: samsung-dsim: Add module init, exit Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02 ` [RFC PATCH 10/17] drm: bridge: samsung-dsim: Update the of_node for port(s) Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02 ` [RFC PATCH 11/17] drm: bridge: samsung-dsim: Find the possible DSI devices Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02 ` [RFC PATCH 12/17] dt-bindings: display: bridge: samsung,mipi-dsim: Add i.MX8MM support Jagan Teki
2021-07-04  9:02   ` [RFC PATCH 12/17] dt-bindings: display: bridge: samsung, mipi-dsim: " Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-14 22:59   ` [RFC PATCH 12/17] dt-bindings: display: bridge: samsung,mipi-dsim: " Rob Herring
2021-07-14 22:59     ` Rob Herring
2021-07-14 22:59     ` Rob Herring
2021-07-04  9:02 ` [RFC PATCH 13/17] drm: bridge: samsung-dsim: " Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02 ` [RFC PATCH 14/17] drm: bridge: samsung-dsim: Add input_bus_flags Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02 ` [RFC PATCH 15/17] drm: bridge: samsung-dsim: Move DSI init in bridge enable Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02 ` [RFC PATCH 16/17] drm: bridge: samsung-dsim: Fix PLL_P offset Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-25 17:48   ` Sam Ravnborg
2021-07-25 17:48     ` Sam Ravnborg
2021-07-04  9:02 ` [RFC PATCH 17/17] drm: bridge: samsung-dsim: Add bridge mode_fixup Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-04  9:02   ` Jagan Teki
2021-07-25 17:50   ` Sam Ravnborg
2021-07-25 17:50     ` Sam Ravnborg
2021-07-25 17:05 ` [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge Sam Ravnborg
2021-07-25 17:05   ` Sam Ravnborg
2021-07-25 17:13   ` Jagan Teki
2021-07-25 17:13     ` Jagan Teki
2021-07-25 17:13     ` Jagan Teki
2021-10-05 21:43     ` Tim Harvey
2021-10-05 21:43       ` Tim Harvey
2021-12-09  8:36       ` Michael Nazzareno Trimarchi
2021-12-09  8:36         ` Michael Nazzareno Trimarchi
2021-12-09  8:36         ` Michael Nazzareno Trimarchi
2021-12-09 16:40         ` Tim Harvey
2021-12-09 16:40           ` Tim Harvey
2021-12-09 16:40           ` Tim Harvey
2021-12-09 17:09           ` Michael Nazzareno Trimarchi
2021-12-09 17:09             ` Michael Nazzareno Trimarchi
2021-12-09 17:09             ` Michael Nazzareno Trimarchi
2021-12-09 17:57             ` Tim Harvey
2021-12-09 17:57               ` Tim Harvey
2021-12-09 17:57               ` Tim Harvey
2021-12-09 20:24             ` Lucas Stach
2021-12-09 20:24               ` Lucas Stach
2021-12-09 20:24               ` Lucas Stach
2021-12-09 21:24               ` Michael Nazzareno Trimarchi
2021-12-09 21:24                 ` Michael Nazzareno Trimarchi
2021-12-09 21:24                 ` Michael Nazzareno Trimarchi
2021-12-15 13:34                 ` Adam Ford
2021-12-15 13:34                   ` Adam Ford
2021-12-15 13:34                   ` Adam Ford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YP2cuisYfklwTUth@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=daniel.vetter@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=inki.dae@samsung.com \
    --cc=jagan@amarulasolutions.com \
    --cc=jy0922.shim@samsung.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=narmstrong@baylibre.com \
    --cc=robert.foss@linaro.org \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.