From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
Christoph Hellwig <hch@lst.de>,
"Darrick J . Wong" <djwong@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Huang Jianan <huangjianan@oppo.com>,
linux-erofs@lists.ozlabs.org,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7] iomap: make inline data support more flexible
Date: Mon, 26 Jul 2021 16:17:19 +0800 [thread overview]
Message-ID: <YP5vj0c56iMLoDfS@B-P7TQMD6M-0146.local> (raw)
In-Reply-To: <CAHpGcMKZP8b3TbRv3D-pcrE_iDU5TKUFHst9emuQmRPntFSArA@mail.gmail.com>
On Mon, Jul 26, 2021 at 10:08:06AM +0200, Andreas Grünbacher wrote:
> Am Mo., 26. Juli 2021 um 06:00 Uhr schrieb Gao Xiang
...
> >
> > iomap_inline_buf() was suggested by Darrick. From my point of view,
> > I think it's better since it's a part of iomap->inline_data due to
> > pos involved.
>
> I find iomap_inline_buf a bit more confusing because it's not
> immediately obvious that "buf" == "data".
>
> I'll send an updated version.
Okay, thank you very much!
Thanks,
Gao Xiang
>
> Thanks,
> Andreas
WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
"Darrick J . Wong" <djwong@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
linux-erofs@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v7] iomap: make inline data support more flexible
Date: Mon, 26 Jul 2021 16:17:19 +0800 [thread overview]
Message-ID: <YP5vj0c56iMLoDfS@B-P7TQMD6M-0146.local> (raw)
In-Reply-To: <CAHpGcMKZP8b3TbRv3D-pcrE_iDU5TKUFHst9emuQmRPntFSArA@mail.gmail.com>
On Mon, Jul 26, 2021 at 10:08:06AM +0200, Andreas Grünbacher wrote:
> Am Mo., 26. Juli 2021 um 06:00 Uhr schrieb Gao Xiang
...
> >
> > iomap_inline_buf() was suggested by Darrick. From my point of view,
> > I think it's better since it's a part of iomap->inline_data due to
> > pos involved.
>
> I find iomap_inline_buf a bit more confusing because it's not
> immediately obvious that "buf" == "data".
>
> I'll send an updated version.
Okay, thank you very much!
Thanks,
Gao Xiang
>
> Thanks,
> Andreas
next prev parent reply other threads:[~2021-07-26 8:17 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 17:41 [PATCH v7] iomap: make inline data support more flexible Gao Xiang
2021-07-23 17:41 ` Gao Xiang
2021-07-23 19:40 ` Matthew Wilcox
2021-07-23 19:40 ` Matthew Wilcox
2021-07-24 0:54 ` Gao Xiang
2021-07-24 0:54 ` Gao Xiang
2021-07-25 21:39 ` Andreas Grünbacher
2021-07-25 21:39 ` Andreas Grünbacher
2021-07-25 22:16 ` Andreas Gruenbacher
2021-07-25 22:16 ` Andreas Gruenbacher
2021-07-26 2:36 ` Gao Xiang
2021-07-26 2:36 ` Gao Xiang
2021-07-26 7:22 ` Andreas Gruenbacher
2021-07-26 7:22 ` Andreas Gruenbacher
2021-07-26 7:38 ` Gao Xiang
2021-07-26 7:38 ` Gao Xiang
2021-07-26 21:36 ` Darrick J. Wong
2021-07-26 21:36 ` Darrick J. Wong
2021-07-26 22:20 ` Andreas Grünbacher
2021-07-26 22:20 ` Andreas Grünbacher
2021-07-26 3:06 ` Matthew Wilcox
2021-07-26 3:06 ` Matthew Wilcox
2021-07-26 6:56 ` Andreas Gruenbacher
2021-07-26 6:56 ` Andreas Gruenbacher
2021-07-26 4:00 ` Gao Xiang
2021-07-26 4:00 ` Gao Xiang
2021-07-26 8:08 ` Andreas Grünbacher
2021-07-26 8:08 ` Andreas Grünbacher
2021-07-26 8:17 ` Gao Xiang [this message]
2021-07-26 8:17 ` Gao Xiang
2021-07-26 11:06 ` Andreas Gruenbacher
2021-07-26 11:06 ` Andreas Gruenbacher
2021-07-26 12:17 ` Christoph Hellwig
2021-07-26 12:17 ` Christoph Hellwig
2021-07-26 12:27 ` Andreas Grünbacher
2021-07-26 12:27 ` Andreas Grünbacher
2021-07-26 12:50 ` Gao Xiang
2021-07-26 12:50 ` Gao Xiang
2021-07-26 13:10 ` Andreas Gruenbacher
2021-07-26 13:27 ` Christoph Hellwig
2021-07-26 13:27 ` Christoph Hellwig
2021-07-27 8:20 ` David Sterba
2021-07-27 8:20 ` David Sterba
2021-07-27 13:35 ` Matthew Wilcox
2021-07-27 15:04 ` Gao Xiang
2021-07-27 15:04 ` Gao Xiang
2021-07-27 16:53 ` David Sterba
2021-07-27 16:53 ` David Sterba
2021-07-26 12:32 ` Matthew Wilcox
2021-07-26 12:32 ` Matthew Wilcox
2021-07-26 13:03 ` Andreas Gruenbacher
2021-07-26 13:03 ` Andreas Gruenbacher
2021-07-26 13:12 ` Gao Xiang
2021-07-26 13:12 ` Gao Xiang
2021-07-26 13:30 ` Christoph Hellwig
2021-07-26 8:08 ` Joseph Qi
2021-07-26 8:08 ` Joseph Qi
2021-08-01 10:29 Andreas Gruenbacher
2021-08-01 10:29 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP5vj0c56iMLoDfS@B-P7TQMD6M-0146.local \
--to=hsiangkao@linux.alibaba.com \
--cc=agruenba@redhat.com \
--cc=andreas.gruenbacher@gmail.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=huangjianan@oppo.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.