All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>,
	Lee Jones <lee.jones@linaro.org>, Andy Gross <agross@kernel.org>,
	Balaji Prakash J <bjagadee@codeaurora.org>,
	Robert Marko <robert.marko@sartura.hr>,
	Kathiravan T <kathirav@codeaurora.org>,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 3/4] dt-bindings: pwm: add IPQ6018 binding
Date: Mon, 26 Jul 2021 10:48:32 -0700	[thread overview]
Message-ID: <YP71cMSjuvmiREda@ripper> (raw)
In-Reply-To: <87h7ghwwcb.fsf@tarshish>

On Sun 25 Jul 21:08 PDT 2021, Baruch Siach wrote:

> Hi Bjorn,
> 
> On Sun, Jul 25 2021, Bjorn Andersson wrote:
> > On Thu 22 Jul 05:01 CDT 2021, Baruch Siach wrote:
> >> +  clocks:
> >> +    maxItems: 1
> >> +
> >> +  clock-names:
> >> +    const: core
> >
> > With a single clock, it's nice to skip the -names.
> 
> I find it nicer and better for forward compatibility with hardware
> variants the might introduce more clocks.
> 

Do you foresee any need for forward compatibility? What other clocks
would this binding have to refer to?

That said, you'd achieve the same forward compatibility by just
making sure that the current clock is the first on in the amended
binding (which you have to do with or without -names).

> Are there any downsides to -names?
> 

Look at the number of places in a typical dts that we could have added
clock-names, reg-names, interrupt-names, power-domain-names etc for a
single cell.

I do find it beneficial to keep things cleaner and sticking with the
design of "single resource has no -names".

Regards,
Bjorn

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>,
	Lee Jones <lee.jones@linaro.org>, Andy Gross <agross@kernel.org>,
	Balaji Prakash J <bjagadee@codeaurora.org>,
	Robert Marko <robert.marko@sartura.hr>,
	Kathiravan T <kathirav@codeaurora.org>,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 3/4] dt-bindings: pwm: add IPQ6018 binding
Date: Mon, 26 Jul 2021 10:48:32 -0700	[thread overview]
Message-ID: <YP71cMSjuvmiREda@ripper> (raw)
In-Reply-To: <87h7ghwwcb.fsf@tarshish>

On Sun 25 Jul 21:08 PDT 2021, Baruch Siach wrote:

> Hi Bjorn,
> 
> On Sun, Jul 25 2021, Bjorn Andersson wrote:
> > On Thu 22 Jul 05:01 CDT 2021, Baruch Siach wrote:
> >> +  clocks:
> >> +    maxItems: 1
> >> +
> >> +  clock-names:
> >> +    const: core
> >
> > With a single clock, it's nice to skip the -names.
> 
> I find it nicer and better for forward compatibility with hardware
> variants the might introduce more clocks.
> 

Do you foresee any need for forward compatibility? What other clocks
would this binding have to refer to?

That said, you'd achieve the same forward compatibility by just
making sure that the current clock is the first on in the amended
binding (which you have to do with or without -names).

> Are there any downsides to -names?
> 

Look at the number of places in a typical dts that we could have added
clock-names, reg-names, interrupt-names, power-domain-names etc for a
single cell.

I do find it beneficial to keep things cleaner and sticking with the
design of "single resource has no -names".

Regards,
Bjorn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-26 17:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 10:01 [PATCH v6 1/4] arm64: dts: ipq6018: correct TCSR block area Baruch Siach
2021-07-22 10:01 ` Baruch Siach
2021-07-22 10:01 ` [PATCH v6 2/4] pwm: driver for qualcomm ipq6018 pwm block Baruch Siach
2021-07-22 10:01   ` Baruch Siach
2021-07-25 18:35   ` Bjorn Andersson
2021-07-25 18:35     ` Bjorn Andersson
2021-07-26  4:31     ` Baruch Siach
2021-07-26  4:31       ` Baruch Siach
2021-07-22 10:01 ` [PATCH v6 3/4] dt-bindings: pwm: add IPQ6018 binding Baruch Siach
2021-07-22 10:01   ` Baruch Siach
2021-07-23 23:03   ` Rob Herring
2021-07-23 23:03     ` Rob Herring
2021-07-25 18:27   ` Bjorn Andersson
2021-07-25 18:27     ` Bjorn Andersson
2021-07-26  4:08     ` Baruch Siach
2021-07-26  4:08       ` Baruch Siach
2021-07-26 17:48       ` Bjorn Andersson [this message]
2021-07-26 17:48         ` Bjorn Andersson
2021-07-26 20:38     ` Rob Herring
2021-07-26 20:38       ` Rob Herring
2021-07-22 10:01 ` [PATCH v6 4/4] arm64: dts: ipq6018: add pwm node Baruch Siach
2021-07-22 10:01   ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YP71cMSjuvmiREda@ripper \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=baruch@tkos.co.il \
    --cc=bjagadee@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kathirav@codeaurora.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.