From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E2DC4338F for ; Mon, 26 Jul 2021 18:44:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15C0C60F59 for ; Mon, 26 Jul 2021 18:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231791AbhGZSDa (ORCPT ); Mon, 26 Jul 2021 14:03:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbhGZSD3 (ORCPT ); Mon, 26 Jul 2021 14:03:29 -0400 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ECBEC061757 for ; Mon, 26 Jul 2021 11:43:57 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id E049E59F; Mon, 26 Jul 2021 20:43:52 +0200 (CEST) Date: Mon, 26 Jul 2021 20:43:28 +0200 From: Joerg Roedel To: Robin Murphy Cc: will@kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suravee.suthikulpanit@amd.com, baolu.lu@linux.intel.com, john.garry@huawei.com, dianders@chromium.org Subject: Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types Message-ID: References: <04220b3420c2c513490450f37de109182364f235.1626888445.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 26, 2021 at 02:09:00PM +0100, Robin Murphy wrote: > Ha, I had exactly that at one point, except I think in the order of > iommu_is_dma_domain() :) That name is fine too :) > The end result didn't seem to give enough extra clarity to justify the > header churn for me, but I'm happy to be wrong about that if you prefer. Developers look more into the code than into headers, so I think the header churn is worth it to improve code readability. But we can do that on-top of these changes in an extra patch-set which also introduces helpers for other domain types (if it is worth it). Regards, Jörg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB96C4338F for ; Mon, 26 Jul 2021 18:44:03 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BEE660F44 for ; Mon, 26 Jul 2021 18:44:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6BEE660F44 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2E06F4035F; Mon, 26 Jul 2021 18:44:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nynJqX-J4M3a; Mon, 26 Jul 2021 18:44:01 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 03FA640353; Mon, 26 Jul 2021 18:44:00 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C891EC0010; Mon, 26 Jul 2021 18:44:00 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8480BC000E for ; Mon, 26 Jul 2021 18:43:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 66B1682C33 for ; Mon, 26 Jul 2021 18:43:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xCEthxUjwhX1 for ; Mon, 26 Jul 2021 18:43:58 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by smtp1.osuosl.org (Postfix) with ESMTPS id 2C54B82C04 for ; Mon, 26 Jul 2021 18:43:58 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id E049E59F; Mon, 26 Jul 2021 20:43:52 +0200 (CEST) Date: Mon, 26 Jul 2021 20:43:28 +0200 From: Joerg Roedel To: Robin Murphy Subject: Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types Message-ID: References: <04220b3420c2c513490450f37de109182364f235.1626888445.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: linux-kernel@vger.kernel.org, dianders@chromium.org, iommu@lists.linux-foundation.org, will@kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Jul 26, 2021 at 02:09:00PM +0100, Robin Murphy wrote: > Ha, I had exactly that at one point, except I think in the order of > iommu_is_dma_domain() :) That name is fine too :) > The end result didn't seem to give enough extra clarity to justify the > header churn for me, but I'm happy to be wrong about that if you prefer. Developers look more into the code than into headers, so I think the header churn is worth it to improve code readability. But we can do that on-top of these changes in an extra patch-set which also introduces helpers for other domain types (if it is worth it). Regards, J=F6rg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1233C4338F for ; Mon, 26 Jul 2021 18:46:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC2B760F44 for ; Mon, 26 Jul 2021 18:46:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC2B760F44 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Puc6XHwAl+Z1CHApDJHmGYoftUcxIVtOZAX/ARmJtq4=; b=NWBa+9AVQY1HA5 78uYW0JIRseiC1W/c96sTf1SJKZODnQJ677JhHokr7LDH5kNUw9zQZ0XerK77Hco+ujbyEf4ODu7G 68b+jfp3Y1VFLGgK+wRimaXwhnRzpddduwKx62pzSnHIyUo2UKdfs6gI/jC6giNA9Ssm/aOOQ8ftx nSDMxqRv/1FWx6xiQqcnuTJZiNwyv8l+2l5LFNx76TSEipgqH/oUsilaDPC/gFwV/k528mGfLctZz zcc+chra9TjRdDcexAFiJofQxlgLewJ7wSN+u7UBLrhsQh28myES/bSNYtBn08VYhxGQzllJIrfwq OJ2ZqabBpDVwcvp2Dmow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m85a6-00CGOQ-Eh; Mon, 26 Jul 2021 18:44:02 +0000 Received: from 8bytes.org ([2a01:238:4383:600:38bc:a715:4b6d:a889] helo=theia.8bytes.org) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m85a2-00CGN9-E5 for linux-arm-kernel@lists.infradead.org; Mon, 26 Jul 2021 18:43:59 +0000 Received: by theia.8bytes.org (Postfix, from userid 1000) id E049E59F; Mon, 26 Jul 2021 20:43:52 +0200 (CEST) Date: Mon, 26 Jul 2021 20:43:28 +0200 From: Joerg Roedel To: Robin Murphy Cc: will@kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suravee.suthikulpanit@amd.com, baolu.lu@linux.intel.com, john.garry@huawei.com, dianders@chromium.org Subject: Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types Message-ID: References: <04220b3420c2c513490450f37de109182364f235.1626888445.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_114358_658105_48D9F18B X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 26, 2021 at 02:09:00PM +0100, Robin Murphy wrote: > Ha, I had exactly that at one point, except I think in the order of > iommu_is_dma_domain() :) That name is fine too :) > The end result didn't seem to give enough extra clarity to justify the > header churn for me, but I'm happy to be wrong about that if you prefer. Developers look more into the code than into headers, so I think the header churn is worth it to improve code readability. But we can do that on-top of these changes in an extra patch-set which also introduces helpers for other domain types (if it is worth it). Regards, J=F6rg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel