From: Matthew Bobrowski <repnop@google.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
Christian Brauner <christian.brauner@ubuntu.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH v3 0/5] Add pidfd support to the fanotify API
Date: Tue, 27 Jul 2021 10:16:40 +1000 [thread overview]
Message-ID: <YP9QaEaCWvUV4Qie@google.com> (raw)
In-Reply-To: <YP9AMGlGCuItQgJb@google.com>
On Tue, Jul 27, 2021 at 09:07:28AM +1000, Matthew Bobrowski wrote:
> On Wed, Jul 21, 2021 at 10:06:56AM +0300, Amir Goldstein wrote:
> > On Wed, Jul 21, 2021 at 9:17 AM Matthew Bobrowski <repnop@google.com> wrote:
> > >
> > > Hey Jan/Amir/Christian,
> > >
> > > This is an updated version of the FAN_REPORT_PIDFD series which contains
> > > the addressed nits from the previous review [0]. As per request, you can
> > > also find the draft LTP tests here [1] and man-pages update for this new
> > > API change here [2].
> > >
> > > [0] https://lore.kernel.org/linux-fsdevel/cover.1623282854.git.repnop@google.com/
> > > [1] https://github.com/matthewbobrowski/ltp/commits/fanotify_pidfd_v2
> > > [2] https://github.com/matthewbobrowski/man-pages/commits/fanotify_pidfd_v1
> >
> > FWIW, those test and man page drafts look good to me :)
>
> Fantastic, thanks for the review!
>
> I will adjust the minor comments/documentation on patch 5/5 and send
> through an updated series.
Alright, so I've fixed up the git commit message and comment in the source
code so that it's more accurate in terms of when/why FAN_NOPIDFD is
reported.
I'm going to hold with sending through v4 until I have Jan also look peek
and poke at v3 as I want to avoid doing any unnecessary round trips.
/M
next prev parent reply other threads:[~2021-07-27 0:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 6:17 [PATCH v3 0/5] Add pidfd support to the fanotify API Matthew Bobrowski
2021-07-21 6:17 ` [PATCH v3 1/5] kernel/pid.c: remove static qualifier from pidfd_create() Matthew Bobrowski
2021-07-21 6:17 ` [PATCH v3 2/5] kernel/pid.c: implement additional checks upon pidfd_create() parameters Matthew Bobrowski
2021-07-21 6:18 ` [PATCH v3 3/5] fanotify/fanotify_user.c: minor cosmetic adjustments to fid labels Matthew Bobrowski
2021-07-21 6:34 ` Amir Goldstein
2021-07-21 6:18 ` [PATCH v3 4/5] fanotify/fanotify_user.c: introduce a generic info record copying helper Matthew Bobrowski
2021-07-21 6:35 ` Amir Goldstein
2021-07-27 8:16 ` Amir Goldstein
2021-07-27 12:57 ` Matthew Bobrowski
2021-07-21 6:19 ` [PATCH v3 5/5] fanotify: add pidfd support to the fanotify API Matthew Bobrowski
2021-07-21 7:05 ` Amir Goldstein
2021-07-26 23:04 ` Matthew Bobrowski
2021-07-27 0:23 ` Jann Horn
2021-07-27 4:19 ` Amir Goldstein
2021-07-27 5:10 ` Matthew Bobrowski
2021-07-27 7:03 ` Amir Goldstein
2021-07-27 8:22 ` Christian Brauner
2021-07-27 8:29 ` Christian Brauner
2021-07-29 13:39 ` Jan Kara
2021-07-29 15:13 ` Amir Goldstein
2021-07-30 5:03 ` Amir Goldstein
2021-08-02 12:34 ` Jan Kara
2021-08-02 14:38 ` Amir Goldstein
2021-08-02 20:10 ` Jan Kara
2021-08-03 1:29 ` Matthew Bobrowski
2021-08-03 5:51 ` Amir Goldstein
2021-08-03 9:46 ` Christian Brauner
2021-08-03 9:37 ` Christian Brauner
2021-08-03 10:07 ` Amir Goldstein
2021-08-03 14:04 ` Jan Kara
2021-08-04 3:46 ` Matthew Bobrowski
2021-08-04 12:39 ` Jan Kara
2021-08-05 5:51 ` Matthew Bobrowski
2021-08-05 8:55 ` Jan Kara
2021-08-03 13:39 ` Jan Kara
2021-07-27 12:54 ` Matthew Bobrowski
2021-07-29 22:48 ` Matthew Bobrowski
2021-07-21 7:06 ` [PATCH v3 0/5] Add " Amir Goldstein
2021-07-26 23:07 ` Matthew Bobrowski
2021-07-27 0:16 ` Matthew Bobrowski [this message]
2021-07-29 13:40 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP9QaEaCWvUV4Qie@google.com \
--to=repnop@google.com \
--cc=amir73il@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.