From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27AD5C1B08C for ; Thu, 15 Jul 2021 10:34:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08BF561360 for ; Thu, 15 Jul 2021 10:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241418AbhGOKhP (ORCPT ); Thu, 15 Jul 2021 06:37:15 -0400 Received: from mga06.intel.com ([134.134.136.31]:16970 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231670AbhGOKhO (ORCPT ); Thu, 15 Jul 2021 06:37:14 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="271634220" X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="271634220" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2021 03:34:21 -0700 X-IronPort-AV: E=Sophos;i="5.84,240,1620716400"; d="scan'208";a="452373614" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2021 03:34:17 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1m3yh0-00DhHX-P0; Thu, 15 Jul 2021 13:34:10 +0300 Date: Thu, 15 Jul 2021 13:34:10 +0300 From: Andy Shevchenko To: Jia He Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Jonathan Corbet , Alexander Viro , Linus Torvalds , "Peter Zijlstra (Intel)" , Eric Biggers , "Ahmed S. Darwish" , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , nd@arm.com Subject: Re: [PATCH v7 1/5] d_path: fix Kernel doc validator complaints Message-ID: References: <20210715011407.7449-1-justin.he@arm.com> <20210715011407.7449-2-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715011407.7449-2-justin.he@arm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 09:14:03AM +0800, Jia He wrote: > Kernel doc validator complains: > Function parameter or member 'p' not described in 'prepend_name' > Excess function parameter 'buffer' description in 'prepend_name' Yup! Reviewed-by: Andy Shevchenko > Fixes: ad08ae586586 ("d_path: introduce struct prepend_buffer") > Cc: Al Viro > Signed-off-by: Jia He > --- > fs/d_path.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/fs/d_path.c b/fs/d_path.c > index 23a53f7b5c71..4eb31f86ca88 100644 > --- a/fs/d_path.c > +++ b/fs/d_path.c > @@ -33,9 +33,8 @@ static void prepend(struct prepend_buffer *p, const char *str, int namelen) > > /** > * prepend_name - prepend a pathname in front of current buffer pointer > - * @buffer: buffer pointer > - * @buflen: allocated length of the buffer > - * @name: name string and length qstr structure > + * @p: prepend buffer which contains buffer pointer and allocated length > + * @name: name string and length qstr structure > * > * With RCU path tracing, it may race with d_move(). Use READ_ONCE() to > * make sure that either the old or the new name pointer and length are > @@ -108,8 +107,7 @@ static int __prepend_path(const struct dentry *dentry, const struct mount *mnt, > * prepend_path - Prepend path string to a buffer > * @path: the dentry/vfsmount to report > * @root: root vfsmnt/dentry > - * @buffer: pointer to the end of the buffer > - * @buflen: pointer to buffer length > + * @p: prepend buffer which contains buffer pointer and allocated length > * > * The function will first try to write out the pathname without taking any > * lock other than the RCU read lock to make sure that dentries won't go away. > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko