From: Greg KH <gregkh@linuxfoundation.org>
To: Xiaochen Shen <xiaochen.shen@intel.com>
Cc: stable@vger.kernel.org, sashal@kernel.org, shuah@kernel.org,
tony.luck@intel.com, fenghua.yu@intel.com,
reinette.chatre@intel.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, pei.p.jia@intel.com
Subject: Re: [PATCH 5.12] selftests/resctrl: Fix incorrect parsing of option "-t"
Date: Thu, 15 Jul 2021 12:48:36 +0200 [thread overview]
Message-ID: <YPAShFw2BkuYYzlq@kroah.com> (raw)
In-Reply-To: <1626076523-924-1-git-send-email-xiaochen.shen@intel.com>
On Mon, Jul 12, 2021 at 03:55:23PM +0800, Xiaochen Shen wrote:
> commit 1421ec684a43379b2aa3cfda20b03d38282dc990 upstream.
>
> Resctrl test suite accepts command line argument "-t" to specify the
> unit tests to run in the test list (e.g., -t mbm,mba,cmt,cat) as
> documented in the help.
>
> When calling strtok() to parse the option, the incorrect delimiters
> argument ":\t" is used. As a result, passing "-t mbm,mba,cmt,cat" throws
> an invalid option error.
>
> Fix this by using delimiters argument "," instead of ":\t" for parsing
> of unit tests list. At the same time, remove the unnecessary "spaces"
> between the unit tests in help documentation to prevent confusion.
>
> Fixes: 790bf585b0ee ("selftests/resctrl: Add Cache Allocation Technology (CAT) selftest")
> Fixes: 78941183d1b1 ("selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest")
> Fixes: ecdbb911f22d ("selftests/resctrl: Add MBM test")
> Fixes: 034c7678dd2c ("selftests/resctrl: Add README for resctrl tests")
> Cc: stable@vger.kernel.org
> Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
> tools/testing/selftests/resctrl/README | 2 +-
> tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
Both now queued up, thanks.
greg k-h
prev parent reply other threads:[~2021-07-15 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 13:06 FAILED: patch "[PATCH] selftests/resctrl: Fix incorrect parsing of option "-t"" failed to apply to 5.12-stable tree gregkh
2021-07-12 7:55 ` [PATCH 5.12] selftests/resctrl: Fix incorrect parsing of option "-t" Xiaochen Shen
2021-07-15 10:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPAShFw2BkuYYzlq@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pei.p.jia@intel.com \
--cc=reinette.chatre@intel.com \
--cc=sashal@kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=xiaochen.shen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.