All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Matyukevich <geomatsi@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/3] gemalto: add radio-settings driver
Date: Thu, 15 Jul 2021 22:01:52 +0300	[thread overview]
Message-ID: <YPCGIIuYLM2Loc7W@curiosity> (raw)
In-Reply-To: <2a42248f-7c99-5f24-a450-651645ec366c@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

Hello Denis,

> > Add support for Gemalto specific radio settings.
> > 
> > ---
> >   Makefile.am                           |   1 +
> >   drivers/gemaltomodem/gemaltomodem.c   |   2 +
> >   drivers/gemaltomodem/gemaltomodem.h   |   3 +
> >   drivers/gemaltomodem/radio-settings.c | 267 ++++++++++++++++++++++++++
> >   4 files changed, 273 insertions(+)
> >   create mode 100644 drivers/gemaltomodem/radio-settings.c
> > 
> 
> I went ahead and applied this with a 2 lines amended: changing 'enum
> ofono_access_mode' to 'unsigned int'.  I recently updated all the drivers in
> commit 1d86dbc6 ("radio-settings: Do not use enum ofono_access_mode").  So I
> did a similar amend here for consistency.

Ok, thanks. After enum ofono_access_mode has been removed, it is possible
to convert all the 'ifs' into 'switch' branches in the function
gemalto_set_rat_mode. I will test and send a cleanup patch.

Regards,
Sergey

  reply	other threads:[~2021-07-15 19:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-04 15:53 [PATCH 0/3] gemalto: radio-setings driver Sergey Matyukevich
2021-07-04 15:53 ` [PATCH 1/3] gemalto: add radio-settings driver Sergey Matyukevich
2021-07-15 18:12   ` Denis Kenzior
2021-07-15 19:01     ` Sergey Matyukevich [this message]
2021-07-04 15:53 ` [PATCH 2/3] plugins: gemalto: add radio-settings atom Sergey Matyukevich
2021-07-15 18:12   ` Denis Kenzior
2021-07-04 15:53 ` [PATCH 3/3] plugins: gemalto: move ussd atom to post_online Sergey Matyukevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPCGIIuYLM2Loc7W@curiosity \
    --to=geomatsi@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.