All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: huangy81@chinatelecom.cn
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Chuan Zheng <zhengchuan@huawei.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 0/3] support dirtyrate measurement with dirty bitmap
Date: Thu, 15 Jul 2021 17:00:07 -0400	[thread overview]
Message-ID: <YPCh12e+L3ORKZKb@t490s> (raw)
In-Reply-To: <cover.1626354884.git.huangy81@chinatelecom.cn>

On Thu, Jul 15, 2021 at 11:51:30PM +0800, huangy81@chinatelecom.cn wrote:
> Hyman Huang(黄勇) (3):
>   KVM: introduce kvm_get_manual_dirty_log_protect
>   memory: introduce DirtyRateDirtyPages and util function
>   migration/dirtyrate: implement dirty-bitmap dirtyrate calculation
> 
>  accel/kvm/kvm-all.c     |   6 +++
>  hmp-commands.hx         |   9 ++--
>  include/exec/ram_addr.h |  19 ++++++++
>  include/sysemu/kvm.h    |   1 +
>  migration/dirtyrate.c   | 118 ++++++++++++++++++++++++++++++++++++++++++++----
>  migration/trace-events  |   1 +
>  qapi/migration.json     |   6 ++-
>  7 files changed, 145 insertions(+), 15 deletions(-)

Yeah this diff looks much nicer. :)

I still have a few last comments here and there, please see each patch.  Thanks.

-- 
Peter Xu



      parent reply	other threads:[~2021-07-15 21:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15 15:51 [PATCH v3 0/3] support dirtyrate measurement with dirty bitmap huangy81
     [not found] ` <cover.1626364220.git.huangy81@chinatelecom.cn>
2021-07-15 15:51   ` [PATCH v3 1/3] KVM: introduce kvm_get_manual_dirty_log_protect huangy81
2021-07-15 15:51   ` [PATCH v3 2/3] memory: introduce DirtyRateDirtyPages and util function huangy81
2021-07-15 20:49     ` Peter Xu
2021-07-15 15:51   ` [PATCH v3 3/3] migration/dirtyrate: implement dirty-bitmap dirtyrate calculation huangy81
2021-07-15 20:58     ` Peter Xu
2021-07-15 21:00 ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPCh12e+L3ORKZKb@t490s \
    --to=peterx@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=huangy81@chinatelecom.cn \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=zhengchuan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.