From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DCD1C636CA for ; Fri, 16 Jul 2021 02:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F9C4613D9 for ; Fri, 16 Jul 2021 02:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233439AbhGPCxD (ORCPT ); Thu, 15 Jul 2021 22:53:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232046AbhGPCxB (ORCPT ); Thu, 15 Jul 2021 22:53:01 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AE44C06175F; Thu, 15 Jul 2021 19:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gMlvBLObPJT3YmRhs9iQMwy3E2OqoakIoEKCEfOZcX0=; b=vgvSRBZIZXuXoEKicIy49w4iCn wSG58yq2P84KKKFtFY0/rJBrDjJXEJ/r1wBz0F75bdK/ezr9mVRkz5jXDQafYO44tdPl7F5TPcfMa avJEDz5F+SP1qVC4yDW7y79z5eDfliLvSRLuna82d9T75Gej7INWQO7oOsi9lstGyp0ZHtvTUxpAO iI67mJaorxloEa4843ZDLCAFsXc2Jjufz7HhWOdkdLGt+xDLR7g22+YnaZi3Kxjmz7KdkYKTxHqim 4FnfHuKt5zD7+6N6pOFZk/54EZs99VuenWAuh4/uqCzzzijpz9hH31GIw8Q9syQZkQ0PTQgupw+6M MZ/J3tLA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4Dut-00455o-4q; Fri, 16 Jul 2021 02:49:38 +0000 Date: Fri, 16 Jul 2021 03:49:31 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 128/138] iomap: Support multi-page folios in invalidatepage Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-129-willy@infradead.org> <20210715221018.GT22357@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715221018.GT22357@magnolia> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 03:10:18PM -0700, Darrick J. Wong wrote: > On Thu, Jul 15, 2021 at 04:36:54AM +0100, Matthew Wilcox (Oracle) wrote: > > If we're punching a hole in a multi-page folio, we need to remove the > > per-page iomap data as the folio is about to be split and each page will > > need its own. This means that writepage can now come across a page with > > no iop allocated, so remove the assertion that there is already one, > > and just create one (with the uptodate bits set) if there isn't one. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Lol, Andreas already did the bottom half of the change for you. Heh, yes, I copy-and-pasted it from this patch ;-) Thanks for merging it!