From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B90FEC12002 for ; Fri, 16 Jul 2021 13:04:04 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B358613F2 for ; Fri, 16 Jul 2021 13:04:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B358613F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.157183.290120 (Exim 4.92) (envelope-from ) id 1m4NVT-00080f-Kb; Fri, 16 Jul 2021 13:03:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 157183.290120; Fri, 16 Jul 2021 13:03:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m4NVT-00080Y-HN; Fri, 16 Jul 2021 13:03:55 +0000 Received: by outflank-mailman (input) for mailman id 157183; Fri, 16 Jul 2021 13:03:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m4NVS-00080B-3C for xen-devel@lists.xenproject.org; Fri, 16 Jul 2021 13:03:54 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 44da7963-e636-11eb-8970-12813bfff9fa; Fri, 16 Jul 2021 13:03:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44da7963-e636-11eb-8970-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1626440632; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=paVfQErJEQq2cpAhiw6I0NXZW70DeTfzJcL8T9D58XM=; b=V2HEVAa7YqX47sE0GCLeD3Txp/COVXiPT0OpZW/J2tv66FAK54vMIox4 BeU2FnP7B8XBd1Hip1j6pTEhK/5pclnUdf9zMNIwYXEfb4sTKvMs1y0rB I+YE5dH7ond69BWcc5Z7ICRZkS1LU74jllNN9nye67fqJGssoybXZY+Hc 8=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: K1DqCOEy5/NlMJ9XKUN/sy+j2xrU2L6umDSH7WUAFEN+u4DzPemx7iEjnh32FLYtalDn5uRZGQ Ly9LICzu0f1+KC9B1pqhvpoZ3mOKUyRDGir+0bFEOdDqvkjyuC2cd3o/Sjqa0wVbfeiMZFSUkh GvChFKg2oFaihzfKMdQq7syVPtC3o3BPh3XEDeVoiLc+gZFiHVhj0XPSX4OgHOHdizDejDPKja ++A1Pa9y/ve5K/8fFdS9mgAMtmgWre486IGZ4r+Q/ir3ObD8gNfQdw2L4VibsMpgWl7GiHAtvk 5Bg= X-SBRS: 5.1 X-MesageID: 48490403 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ROKLYaC4aPXyfVjlHelW55DYdb4zR+YMi2TDt3oddfWaSKylfq GV7ZAmPHrP4gr5N0tOpTntAse9qBDnhPtICOsqTNSftWDd0QPFEGgL1+DfKlbbak/DH4BmtJ uJc8JFeaDN5VoRt7eH3OFveexQv+Vu88qT9JnjJ28Gd3AMV0n5hT0JcTpyFCdNNW97LKt8Lr WwzOxdqQGtfHwGB/7LfEXsD4D41qT2fIuNW29/OyIa X-IronPort-AV: E=Sophos;i="5.84,244,1620705600"; d="scan'208";a="48490403" Date: Fri, 16 Jul 2021 14:03:49 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Juergen Gross , George Dunlap , Ian Jackson Subject: Re: [PATCH v2 01/13] libxl/x86: check return value of SHADOW_OP_SET_ALLOCATION domctl Message-ID: References: <0bebfe8c-6897-dc8b-7fe0-9127d4996eb8@suse.com> <4d1e5a4d-05cf-964a-bc4b-9eecf26e58bb@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4d1e5a4d-05cf-964a-bc4b-9eecf26e58bb@suse.com> On Mon, Jul 05, 2021 at 05:11:31PM +0200, Jan Beulich wrote: > The hypervisor may not have enough memory to satisfy the request. While > there, make the unit of the value clear by renaming the local variable. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich > Reviewed-by: Andrew Cooper > --- > v2: Rename local variables. Also log requested value. Don't log errno > explicitly in LOGED() (nor function return value). Integrate into > series. Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD