Re: [RFT] Testing 1.22

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Thu, Jul 15, 2021 at 11:31:20PM +0200, Michal Suchánek escreveu:
> Hello,
> 
> when building with system libbpf I get:
> 
> [   40s] make[1]: Nothing to be done for 'preinstall'.
> [   40s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/dwarves-1.21+git175.1ef87b2/build'
> [   40s] Install the project...
> [   40s] /usr/bin/cmake -P cmake_install.cmake
> [   40s] -- Install configuration: "RelWithDebInfo"
> [   40s] -- Installing: /home/abuild/rpmbuild/BUILDROOT/dwarves-1.21+git175.1ef87b2-15.1.ppc64le/usr/bin/codiff
> [   40s] CMake Error at cmake_install.cmake:63 (file):
> [   40s]   file RPATH_CHANGE could not write new RPATH:
> [   40s] 
> [   40s]     
> [   40s] 
> [   40s]   to the file:
> [   40s] 
> [   40s]     /home/abuild/rpmbuild/BUILDROOT/dwarves-1.21+git175.1ef87b2-15.1.ppc64le/usr/bin/codiff
> [   40s] 
> [   40s]   The current RUNPATH is:
> [   40s] 
> [   40s]     /home/abuild/rpmbuild/BUILD/dwarves-1.21+git175.1ef87b2/build:
> [   40s] 
> [   40s]   which does not contain:
> [   40s] 
> [   40s]     /usr/local/lib64:/home/abuild/rpmbuild/BUILD/dwarves-1.21+git175.1ef87b2/build:
> [   40s] 
> [   40s]   as was expected.
> [   40s] 
> [   40s] 
> [   40s] make: *** [Makefile:74: install] Error 1
> [   40s] make: Leaving directory '/home/abuild/rpmbuild/BUILD/dwarves-1.21+git175.1ef87b2/build'
> [   40s] error: Bad exit status from /var/tmp/rpm-tmp.OaGNX4 (%install)
> 
> This is not a problem with embedded libbpf.
> 
> Using system libbpf seems to be new in 1.22

Lucca, can you take a look at this?

Thanks,

- Arnaldo
 
> On Thu, May 27, 2021 at 12:20:53PM -0300, Arnaldo Carvalho de Melo wrote:
> > Hi guys,
> > 
> > 	Its important to have 1.22 out of the door ASAP, so please clone
> > what is in tmp.master and report your results.
> > 
> > 	To make it super easy:
> > 
> > [acme@quaco pahole]$ cd /tmp
> > [acme@quaco tmp]$ git clone git://git.kernel.org/pub/scm/devel/pahole/pahole.git
> > Cloning into 'pahole'...
> > remote: Enumerating objects: 6510, done.
> > remote: Total 6510 (delta 0), reused 0 (delta 0), pack-reused 6510
> > Receiving objects: 100% (6510/6510), 1.63 MiB | 296.00 KiB/s, done.
> > Resolving deltas: 100% (4550/4550), done.
> > [acme@quaco tmp]$ cd pahole/
> > [acme@quaco pahole]$ git checkout origin/tmp.master
> > Note: switching to 'origin/tmp.master'.
> > 
> > You are in 'detached HEAD' state. You can look around, make experimental
> > changes and commit them, and you can discard any commits you make in this
> > state without impacting any branches by switching back to a branch.
> > 
> > If you want to create a new branch to retain commits you create, you may
> > do so (now or later) by using -c with the switch command. Example:
> > 
> >   git switch -c <new-branch-name>
> > 
> > Or undo this operation with:
> > 
> >   git switch -
> > 
> > Turn off this advice by setting config variable advice.detachedHead to false
> > 
> > HEAD is now at 0d17503db0580a66 btf_encoder: fix and complete filtering out zero-sized per-CPU variables
> > [acme@quaco pahole]$ git log --oneline -5
> > 0d17503db0580a66 (HEAD, origin/tmp.master) btf_encoder: fix and complete filtering out zero-sized per-CPU variables
> > fb418f9d8384d3a9 dwarves: Make handling of NULL by destructos consistent
> > f049fe9ebf7aa9c2 dutil: Make handling of NULL by destructos consistent
> > 1512ab8ab6fe76a9 pahole: Make handling of NULL by destructos consistent
> > 1105b7dad2d0978b elf_symtab: Use zfree() where applicable
> > [acme@quaco pahole]$ mkdir build
> > [acme@quaco pahole]$ cd build
> > [acme@quaco build]$ cmake ..
> > <SNIP>
> > -- Build files have been written to: /tmp/pahole/build
> > [acme@quaco build]$ cd ..
> > [acme@quaco pahole]$ make -j8 -C build
> > make: Entering directory '/tmp/pahole/build'
> > <SNIP>
> > [100%] Built target pahole
> > make[1]: Leaving directory '/tmp/pahole/build'
> > make: Leaving directory '/tmp/pahole/build'
> > [acme@quaco pahole]$
> > 
> > Then make sure build/pahole is in your path and try your workloads.
> > 
> > Jiri, Michael, if you could run your tests with this, that would be awesome,
> > 
> > Thanks in advance!
> > 
> > - Arnaldo

-- 

- Arnaldo