From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7671C07E95 for ; Fri, 16 Jul 2021 15:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83291613F6 for ; Fri, 16 Jul 2021 15:32:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240361AbhGPPf2 (ORCPT ); Fri, 16 Jul 2021 11:35:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:54922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240282AbhGPPfW (ORCPT ); Fri, 16 Jul 2021 11:35:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6C328601FC; Fri, 16 Jul 2021 15:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626449545; bh=4u44g4o4WWvRRIK8ATdu4kvIsQfyneMY613u8yi2+pk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wNSA9m+JXcj3cHMJYy4WSx3bAfTf8riLqqZvAQTdub9wcEpeGBeGWAvCWpy+BMlCJ FYxUKlf2BfHiQXr+qgy8bpP34CP4pC5+46sKANA8z2rgG4A/9ED4vpaUjHu9F7xtk3 UPYGs1AmKfWNVBGzFZXHVpBJVakHATfQGjMLSOWw= Date: Fri, 16 Jul 2021 17:32:20 +0200 From: Greg Kroah-Hartman To: Werner Sembach Cc: kernel-team@lists.ubuntu.com, Mario Limonciello , Prike Liang , stable Subject: Re: [SRU][H][PATCH v2 1/1] usb: pci-quirks: disable D3cold on xhci suspend for s2idle on AMD Renoir Message-ID: References: <20210716104010.4889-1-wse@tuxedocomputers.com> <20210716104010.4889-2-wse@tuxedocomputers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Jul 16, 2021 at 05:12:44PM +0200, Werner Sembach wrote: > > Am 16.07.21 um 14:50 schrieb Greg Kroah-Hartman: > > On Fri, Jul 16, 2021 at 12:40:10PM +0200, Werner Sembach wrote: > >> From: Mario Limonciello > >> > >> BugLink: https://bugs.launchpad.net/bugs/1936583 > >> > >> The XHCI controller is required to enter D3hot rather than D3cold for AMD > >> s2idle on this hardware generation. > >> > >> Otherwise, the 'Controller Not Ready' (CNR) bit is not being cleared by > >> host in resume and eventually this results in xhci resume failures during > >> the s2idle wakeup. > >> > >> Link: https://lore.kernel.org/linux-usb/1612527609-7053-1-git-send-email-Prike.Liang@amd.com/ > >> Suggested-by: Prike Liang > >> Signed-off-by: Mario Limonciello > >> Cc: stable # 5.11+ > >> Link: https://lore.kernel.org/r/20210527154534.8900-1-mario.limonciello@amd.com > >> Signed-off-by: Greg Kroah-Hartman > >> (cherry picked from commit d1658268e43980c071dbffc3d894f6f6c4b6732a) > >> Signed-off-by: Werner Sembach > >> --- > >> drivers/usb/host/xhci-pci.c | 7 ++++++- > >> drivers/usb/host/xhci.h | 1 + > >> 2 files changed, 7 insertions(+), 1 deletion(-) > >> > > Any reason you resent us a patch that is already in a stable release? > > > > And why not just use the stable kernel trees as-is? Why attempt to > > cherry-pick random portions of them? > > > > thanks, > > > > greg k-h > > I didn't add the mailing list as recipent for my last replies so here again: > > I only checked the Ubuntu 5.11 tree where the patch is actually missing. > > The 5.8 kernel has other issues because of outdated amdgpu, that's why we never checked the 5.4 kernel. > > Testing for 5.4: often hangs on boot before display manager shows up > > 5.4 + amdgpu-dkms from here: https://www.amd.com/en/support/kb/release-notes/rn-amdgpu-unified-linux-21-20 : Hang on > boot issue gone, but does not suspend anymore, and has graphic glitches. > > Should I add these findings to the SRU? What does any of this have to do with the stable@vger.kernel.org developers?