From: Eryu Guan <guaneryu@gmail.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>, fstests@vger.kernel.org
Subject: Re: [PATCH 0/2] skip tests that don't work with an external log
Date: Sun, 18 Jul 2021 20:54:02 +0800 [thread overview]
Message-ID: <YPQkalv0mmLpsSnZ@desktop> (raw)
In-Reply-To: <20210706174837.GA11571@locust>
On Tue, Jul 06, 2021 at 10:48:37AM -0700, Darrick J. Wong wrote:
> On Mon, Jul 05, 2021 at 12:03:05AM -0400, Theodore Ts'o wrote:
> > I recently tried running xfstests with an external log device, and
> > found a number of failures caused by the fact that we use dmflakey and
> > dmerror to take down a disk to simulate a power failure or a complete
> > hard disk failure. But with an external log device, the tests don't
> > correctly simulate these scenarios, so skip them.
>
> Counter-proposal: If I sent out my series to fix all that[1], would you
> review them?
Yeah, I was going to ask if xfs supports dmflakey tests with external
log dev. So Ted's proposal will break your work.
And if we want to disable dmflakey/dmerror tests with external log only
for ext4, I think we could do it in _require_dm_target() not in
_init_flakey(), something like:
_require_dm_target()
{
local target=$1
......
case "$target" in
flakey|error)
if [ "$FSTYP" == "ext4" -o "$FSTYP" == "ext3" ] && _has_logdev; then
_notrun "dmflakey/dmerror tests don't work with an external log device for $FSTYP"
fi
;;
*)
;;
esac
......
}
Then generic/475 doesn't need any update.
Thanks,
Eryu
>
> --D
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfstests-dev.git/log/?h=dmerror-on-rt-devices
>
> >
> > With these patches, testing with ext4 using an external log is passing
> > almost all of the auto group tests, with the exception of ext4/028
> > (which appears to be a genuine ext4 fsmap bug not handling external
> > log devices correctly).
> >
> > Theodore Ts'o (2):
> > dmflakey: don't run dmflakey tests with an external log device
> > generic/475: skip test when using an external log device
> >
> > common/dmflakey | 4 ++++
> > tests/generic/475 | 4 ++++
> > 2 files changed, 8 insertions(+)
> >
> > --
> > 2.31.0
> >
prev parent reply other threads:[~2021-07-18 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 4:03 [PATCH 0/2] skip tests that don't work with an external log Theodore Ts'o
2021-07-05 4:03 ` [PATCH 1/2] dmflakey: don't run dmflakey tests with an external log device Theodore Ts'o
2021-07-05 4:03 ` [PATCH 2/2] generic/475: skip test when using " Theodore Ts'o
2021-07-06 17:48 ` [PATCH 0/2] skip tests that don't work with an external log Darrick J. Wong
2021-07-18 12:54 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPQkalv0mmLpsSnZ@desktop \
--to=guaneryu@gmail.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.