All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH] erofs: erofs_iomap_end() can be static
Date: Mon, 19 Jul 2021 00:53:25 +0800	[thread overview]
Message-ID: <YPRchcEueihCq6Bo@B-P7TQMD6M-0146.local> (raw)
In-Reply-To: <20210718053043.GA22026@9f5d25f44276>

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

Hi,

On Sun, Jul 18, 2021 at 01:30:43PM +0800, kernel test robot wrote:
> fs/erofs/data.c:133:5: warning: symbol 'erofs_iomap_end' was not declared. Should it be static?
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Thanks, will be applied in the next version!

Thanks,
Gao Xiang

> ---
>  data.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
> index 90b6c27c7abca..fa2f65081b172 100644
> --- a/fs/erofs/data.c
> +++ b/fs/erofs/data.c
> @@ -130,7 +130,7 @@ static int erofs_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
>  	return 0;
>  }
>  
> -int erofs_iomap_end(struct inode *inode, loff_t pos, loff_t length,
> +static int erofs_iomap_end(struct inode *inode, loff_t pos, loff_t length,
>  		ssize_t written, unsigned flags, struct iomap *iomap)
>  {
>  	struct page *ipage = iomap->private;

      reply	other threads:[~2021-07-18 16:53 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16  5:07 [PATCH 0/2] erofs: iomap support for tailpacking cases Gao Xiang
2021-07-16  5:07 ` Gao Xiang
2021-07-16  5:07 ` [PATCH 1/2] iomap: support tail packing inline read Gao Xiang
2021-07-16  5:07   ` Gao Xiang
2021-07-16  9:19   ` Christoph Hellwig
2021-07-16  9:19     ` Christoph Hellwig
2021-07-16  9:46     ` Gao Xiang
2021-07-16  9:46       ` Gao Xiang
2021-07-16 13:47     ` Matthew Wilcox
2021-07-16 13:47       ` Matthew Wilcox
2021-07-16 14:38       ` Matthew Wilcox
2021-07-16 14:38         ` Matthew Wilcox
2021-07-16 13:02   ` Matthew Wilcox
2021-07-16 13:02     ` Matthew Wilcox
2021-07-16 13:56     ` Gao Xiang
2021-07-16 13:56       ` Gao Xiang
2021-07-16 14:44       ` Matthew Wilcox
2021-07-16 15:03         ` Gao Xiang
2021-07-16 15:03           ` Gao Xiang
2021-07-16 15:53           ` Andreas Grünbacher
2021-07-16 15:53             ` Andreas Grünbacher
2021-07-17 13:38             ` Gao Xiang
2021-07-17 13:38               ` Gao Xiang
2021-07-17 15:01               ` Matthew Wilcox
2021-07-17 15:15                 ` Gao Xiang
2021-07-17 15:15                   ` Gao Xiang
2021-07-17 18:40                   ` Matthew Wilcox
2021-07-19 11:19                     ` Christoph Hellwig
2021-07-19 11:19                       ` Christoph Hellwig
2021-07-19 13:45                       ` Gao Xiang
2021-07-19 13:45                         ` Gao Xiang
2021-07-19 11:15               ` Christoph Hellwig
2021-07-19 13:31                 ` Gao Xiang
2021-07-19 13:31                   ` Gao Xiang
2021-07-16  5:07 ` [PATCH 2/2] erofs: convert all uncompressed cases to iomap Gao Xiang
2021-07-16  5:07   ` Gao Xiang
2021-07-18  5:30   ` kernel test robot
2021-07-18  5:30   ` [RFC PATCH] erofs: erofs_iomap_end() can be static kernel test robot
2021-07-18 16:53     ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPRchcEueihCq6Bo@B-P7TQMD6M-0146.local \
    --to=hsiangkao@linux.alibaba.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.