From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============8225333491054442396=="
MIME-Version: 1.0
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH] erofs: erofs_iomap_end() can be static
Date: Mon, 19 Jul 2021 00:53:25 +0800
Message-ID: <YPRchcEueihCq6Bo@B-P7TQMD6M-0146.local>
In-Reply-To: <20210718053043.GA22026@9f5d25f44276>
List-Id: <oe-kbuild-all.lists.linux.dev>

--===============8225333491054442396==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, Jul 18, 2021 at 01:30:43PM +0800, kernel test robot wrote:
> fs/erofs/data.c:133:5: warning: symbol 'erofs_iomap_end' was not declared=
. Should it be static?
> =

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Thanks, will be applied in the next version!

Thanks,
Gao Xiang

> ---
>  data.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> =

> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
> index 90b6c27c7abca..fa2f65081b172 100644
> --- a/fs/erofs/data.c
> +++ b/fs/erofs/data.c
> @@ -130,7 +130,7 @@ static int erofs_iomap_begin(struct inode *inode, lof=
f_t offset, loff_t length,
>  	return 0;
>  }
>  =

> -int erofs_iomap_end(struct inode *inode, loff_t pos, loff_t length,
> +static int erofs_iomap_end(struct inode *inode, loff_t pos, loff_t lengt=
h,
>  		ssize_t written, unsigned flags, struct iomap *iomap)
>  {
>  	struct page *ipage =3D iomap->private;
--===============8225333491054442396==--