From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAFBFC07E9B for ; Mon, 19 Jul 2021 12:40:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2ECC6113E for ; Mon, 19 Jul 2021 12:40:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237044AbhGSL7d (ORCPT ); Mon, 19 Jul 2021 07:59:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:35890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237041AbhGSL7c (ORCPT ); Mon, 19 Jul 2021 07:59:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8B0146113B; Mon, 19 Jul 2021 12:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626698411; bh=ec9aSpU01rDk3L8/1MWG2xSeLpf8itpXYZ3hxC+ULgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XMAYxAts9Xl2J4OPBUKPBvtcBknkVvrEXexP+6Xp4Ju3YIe0sEZVG/ie1iXby6XW8 CjJE12YKdYhcjfSKKUTHmbqLH5D57pbnePca6a8gRTrFk2xTcQQT5HXPrNShRxsOJY Lp+noSbzn3n0jnBo8kQ4Ob2y1Sk+7orMqjH+gG7s= Date: Mon, 19 Jul 2021 14:40:02 +0200 From: Greg KH To: Yang Yingliang Cc: sudipm.mukherjee@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, davem@davemloft.net, sashal@kernel.org Subject: Re: [PATCH 5.4] net: moxa: Use devm_platform_get_and_ioremap_resource() Message-ID: References: <20210716093245.315536-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210716093245.315536-1-yangyingliang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 16, 2021 at 05:32:45PM +0800, Yang Yingliang wrote: > [ Upstream commit 35cba15a504bf4f585bb9d78f47b22b28a1a06b2 ] > > Use devm_platform_get_and_ioremap_resource() to simplify > code and avoid a null-ptr-deref by checking 'res' in it. > > [yyl: since devm_platform_get_and_ioremap_resource() is introduced > in linux-5.7, so just check the return value after calling > platform_get_resource()] > > Signed-off-by: Yang Yingliang > Signed-off-by: David S. Miller > --- > drivers/net/ethernet/moxa/moxart_ether.c | 4 ++++ > 1 file changed, 4 insertions(+) Now queued up, thanks. greg k-h