All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH stable-4.14] PCI: aardvark: Don't rely on jiffies while holding spinlock
Date: Mon, 19 Jul 2021 14:43:37 +0200	[thread overview]
Message-ID: <YPVzeay+kONm6sUv@kroah.com> (raw)
In-Reply-To: <20210716122033.22568-1-pali@kernel.org>

On Fri, Jul 16, 2021 at 02:20:33PM +0200, Pali Rohár wrote:
> From: Remi Pommarel <repk@triplefau.lt>
> 
> commit 7fbcb5da811be7d47468417c7795405058abb3da upstream.
> 
> advk_pcie_wait_pio() can be called while holding a spinlock (from
> pci_bus_read_config_dword()), then depends on jiffies in order to
> timeout while polling on PIO state registers. In the case the PIO
> transaction failed, the timeout will never happen and will also cause
> the cpu to stall.
> 
> This decrements a variable and wait instead of using jiffies.
> 
> Signed-off-by: Remi Pommarel <repk@triplefau.lt>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Reviewed-by: Andrew Murray <andrew.murray@arm.com>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> This is backport to 4.14 kernel. Backport of upstream commit can be done
> automatically by git cherry-pick command if merge.renamelimit variable is
> set to at least 12711.
> ---
>  drivers/pci/host/pci-aardvark.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Also queued up to 4.19, thanks.

greg k-h

      reply	other threads:[~2021-07-19 12:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 12:20 [PATCH stable-4.14] PCI: aardvark: Don't rely on jiffies while holding spinlock Pali Rohár
2021-07-19 12:43 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPVzeay+kONm6sUv@kroah.com \
    --to=greg@kroah.com \
    --cc=pali@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.