From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E37FC07E95 for ; Mon, 19 Jul 2021 15:02:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 051ED61242 for ; Mon, 19 Jul 2021 15:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242702AbhGSOVw (ORCPT ); Mon, 19 Jul 2021 10:21:52 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:33932 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242706AbhGSOUf (ORCPT ); Mon, 19 Jul 2021 10:20:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kAaOYJ4WkAH+VU3g6V5deZBG0j2OSTdbwTHDQarLo/0=; b=qCNYPgSt4w9NG/eazm3PjtEnHn 1VCeMWdqK/F4cAF/xCRs+yIf5Y7KBU5RqGXoFVmJJgDvReOaEVqPvEUcdfD4jPXOFEtG5Y8mmjXwP SIwpkFZh8U2BHys+owukwcAaOVa4IxTproR9MCma4E6z87EFHzPKQQQfQVCbchZgT4hE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m5Ulb-00DuVB-HO; Mon, 19 Jul 2021 17:01:11 +0200 Date: Mon, 19 Jul 2021 17:01:11 +0200 From: Andrew Lunn To: Ruud Bos Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jesse.brandeburg@intel.com" , "anthony.l.nguyen@intel.com" , Richard Cochran Subject: Re: [PATCH net-next 0/4 resend] igb: support PEROUT and EXTTS PTP pin functions on 82580/i354/i350 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 19, 2021 at 02:45:06PM +0000, Ruud Bos wrote: > > From: Andrew Lunn > > Sent: Monday, July 19, 2021 16:29 > > To: Ruud Bos > > Cc: netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org; > > jesse.brandeburg@intel.com; anthony.l.nguyen@intel.com; Richard Cochran > > > > Subject: Re: [PATCH net-next 0/4 resend] igb: support PEROUT and EXTTS > > PTP pin functions on 82580/i354/i350 > > > > On Mon, Jul 19, 2021 at 11:33:11AM +0000, Ruud Bos wrote: > > > The igb driver provides support for PEROUT and EXTTS pin functions that > > > allow adapter external use of timing signals. At Hottinger Bruel & Kjaer we > > > are using the PEROUT function to feed a PTP corrected 1pps signal into an > > > FPGA as cross system synchronized time source. > > > > Please always Cc: The PTP maintainer for PTP patches. > > Richard Cochran > > Thanks, will do that! > Do I need to resend again? It is probably a good idea to resend. It will make it easier for Richard if the patches are in his mailbox. > This is my first ever contribution, so it's all kinda new to me, > sorry :-) Cc: Richard is not so obvious as it should be, since ./scripts/get_maintainers.pl would not of suggested it, since you are not modify the PTP core. It takes a bit of experience to know this. This is the second time something like this has happened recently for Intel Ethernet drivers. The other case was making use of the LED subsystem from within an Ethernet driver, and the LED subsystem maintainers were not Cc:. It would be good if the Intel Maintainers actually took notice of this, they have the experience to know better. I noticed your patches are not threaded. Did you use git send-email? It normally does thread a patchset. The threading keeps the patchset together, which can be important for some of the bots which scoop up patches in emails and run tests on them. Please see if you can fix that in the resend. Andrew