From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF13C07E95 for ; Tue, 20 Jul 2021 10:56:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFEB3610F7 for ; Tue, 20 Jul 2021 10:56:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237886AbhGTKPR (ORCPT ); Tue, 20 Jul 2021 06:15:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:35468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237581AbhGTKF0 (ORCPT ); Tue, 20 Jul 2021 06:05:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 98F9E61186; Tue, 20 Jul 2021 10:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626777964; bh=/O0vv21Cgn0unUo+i8YkezR6Gk++1U7Fdq0xfVx3pkU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h21+U6b9EbzyiLOtuCFLg8M02NiBEj15fSC7Tt2xkk4vtd3ty3Xi+Fc8bgMg9RXUm 5nE82yW69y8nFnKbjCBpSdkI1hgdh62C37t3U6CbJirYsNL+O/8vTkvpjOOSB0kcK+ EfO0/R8qZraMCF0ItGGgPbjIvhr3DlrOkdBWeMq48czuGG4fY93hOF7citD1av19ab 05tP9cBOn+q3hKSrLBeKo1rk05lQml3eTtzL9pjehbMJ1PL7Ee1QDE3gjwwj0kSAJ8 EQb+c9tM1JxeTdDyZrKsOolArdhqPxMErGQrjVT21JNlkycGZmRcy2nm2L3KbeUoHP j/y6hrrx78j2A== Date: Tue, 20 Jul 2021 13:45:57 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Vlastimil Babka , William Kucharski , Christoph Hellwig , "Kirill A . Shutemov" Subject: Re: [PATCH v14 023/138] mm/swap: Add folio_rotate_reclaimable() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-24-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715033704.692967-24-willy@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 04:35:09AM +0100, Matthew Wilcox (Oracle) wrote: > Convert rotate_reclaimable_page() to folio_rotate_reclaimable(). This > eliminates all five of the calls to compound_head() in this function, > saving 75 bytes at the cost of adding 15 bytes to its one caller, > end_page_writeback(). We also save 36 bytes from pagevec_move_tail_fn() > due to using folios there. Net 96 bytes savings. > > Also move its declaration to mm/internal.h as it's only used by filemap.c. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: Christoph Hellwig > Acked-by: Kirill A. Shutemov > --- > include/linux/swap.h | 1 - > mm/filemap.c | 3 ++- > mm/internal.h | 1 + > mm/page_io.c | 4 ++-- > mm/swap.c | 30 ++++++++++++++++-------------- > 5 files changed, 21 insertions(+), 18 deletions(-) Acked-by: Mike Rapoport