From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D020EC07E9B for ; Tue, 20 Jul 2021 15:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B763961164 for ; Tue, 20 Jul 2021 15:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240721AbhGTPFZ (ORCPT ); Tue, 20 Jul 2021 11:05:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240077AbhGTOph (ORCPT ); Tue, 20 Jul 2021 10:45:37 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D3A5C0613DB; Tue, 20 Jul 2021 08:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YMJtZl0zXHIg/quYkGxZ124m2IPJSkonaupGUSsz4Eg=; b=LmHCNdtnyQmWHaZa+nyfYJ9TbM hlWkq/nRtQ+gQeZBatFJyw8v5ISxlLOHOrPJOZGpGTscR2vBu0ynTY3otLp/O+0DYdo8AHvH9U1OZ CexnBvS9QvhGiyRDsimnFgbK0ffkcFhiBi2Nd/J3FW3NMJVoA1HoCZm+gXjwm92SEfPQDFlGEXviJ pGMDTHuSUXpsgvPaE8lGNpGaIJO1+MGDWFs0FYYGgjWcj4IJVs7dkg2h16lwDhXQivyHSMclIAm7I 289weZ1G+Pa2nUUXhyiKPNb7YoHelS2rbxk2G76taXCJ3U0GT1/o6oJz/VyD1GcaLXsgjEuAiLOFb 5ihwf5wA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5raj-008Feq-29; Tue, 20 Jul 2021 15:23:41 +0000 Date: Tue, 20 Jul 2021 16:23:29 +0100 From: Matthew Wilcox To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 000/138] Memory folios Message-ID: References: <20210715033704.692967-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 20, 2021 at 06:17:26PM +0300, Mike Rapoport wrote: > On Tue, Jul 20, 2021 at 01:41:15PM +0100, Matthew Wilcox wrote: > > On Tue, Jul 20, 2021 at 01:54:38PM +0300, Mike Rapoport wrote: > > > Most of the changelogs (at least at the first patches) mention reduction of > > > the kernel size for your configuration on x86. I wonder, what happens if > > > you build the kernel with "non-distro" configuration, e.g. defconfig or > > > tiny.config? > > > > I did an allnoconfig build and that reduced in size by ~2KiB. > > > > > Also, what is the difference on !x86 builds? > > > > I don't generally do non-x86 builds ... feel free to compare for > > yourself! > > I did allnoconfig and defconfig for arm64 and powerpc. > > All execpt arm64::defconfig show decrease by ~1KiB, while arm64::defconfig > was actually increased by ~500 bytes. Which patch did you go up to for that? If you're going past patch 50 or so, then you're starting to add functionality (ie support for arbitrary order pages), so a certain amount of extra code size might be expected. I measured 6KB at patch 32 or so, then between patch 32 & 50 was pretty much a wash. > I didn't dig into objdumps yet. > > I also tried to build arm but it failed with: > > CC fs/remap_range.o > fs/remap_range.c: In function 'vfs_dedupe_file_range_compare': > fs/remap_range.c:250:3: error: implicit declaration of function 'flush_dcache_folio'; did you mean 'flush_cache_louis'? [-Werror=implicit-function-declaration] > 250 | flush_dcache_folio(src_folio); > | ^~~~~~~~~~~~~~~~~~ > | flush_cache_louis > cc1: some warnings being treated as errors Already complained about by the build bot; already fixed. You should maybe look at the git tree if you're doing more than code review.