All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jason Ekstrand <jason@jlekstrand.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Correct the docs for intel_engine_cmd_parser
Date: Tue, 20 Jul 2021 16:26:56 -0400	[thread overview]
Message-ID: <YPcxkGJi9b8jpXII@intel.com> (raw)
In-Reply-To: <YPcxMC1oULxcCSSO@intel.com>

On Tue, Jul 20, 2021 at 04:25:21PM -0400, Rodrigo Vivi wrote:
> On Tue, Jul 20, 2021 at 01:21:08PM -0500, Jason Ekstrand wrote:
> > In c9d9fdbc108a ("drm/i915: Revert "drm/i915/gem: Asynchronous
> > cmdparser""), the parameters to intel_engine_cmd_parser() were altered
> > without updating the docs, causing Fi.CI.DOCS to start failing.
> > 
> > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
> > ---
> >  drivers/gpu/drm/i915/i915_cmd_parser.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915/i915_cmd_parser.c
> > index 322f4d5955a4f..e0403ce9ce692 100644
> > --- a/drivers/gpu/drm/i915/i915_cmd_parser.c
> > +++ b/drivers/gpu/drm/i915/i915_cmd_parser.c
> > @@ -1416,9 +1416,7 @@ static unsigned long *alloc_whitelist(u32 batch_length)
> >   * @batch_offset: byte offset in the batch at which execution starts
> >   * @batch_length: length of the commands in batch_obj
> >   * @shadow: validated copy of the batch buffer in question
> > - * @jump_whitelist: buffer preallocated with intel_engine_cmd_parser_alloc_jump_whitelist()
> > - * @shadow_map: mapping to @shadow vma
> > - * @batch_map: mapping to @batch vma
> > + * @trampoline: true if we need to trampoline into privileged execution
> 
> I was wondering if we should also return the original text, but this one
> here looks better.
> 
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

btw, while on it, I wouldn't mind if you squash some english fixes to
the trampoline documentation block inside this function ;)

> 
> 
> >   *
> >   * Parses the specified batch buffer looking for privilege violations as
> >   * described in the overview.
> > -- 
> > 2.31.1
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-07-20 20:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20 18:21 [Intel-gfx] [PATCH] drm/i915: Correct the docs for intel_engine_cmd_parser Jason Ekstrand
2021-07-20 19:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-07-20 19:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-07-20 20:25 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2021-07-20 20:26   ` Rodrigo Vivi [this message]
2021-07-20 21:04     ` Jason Ekstrand
2021-07-21 10:05       ` Rodrigo Vivi
2021-07-21 15:25         ` Jason Ekstrand
2021-07-21 15:52           ` Rodrigo Vivi
2021-07-20 21:33 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPcxkGJi9b8jpXII@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jason@jlekstrand.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.