From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F15C07E9B for ; Wed, 21 Jul 2021 02:06:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B785611C1 for ; Wed, 21 Jul 2021 02:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231153AbhGUB0M (ORCPT ); Tue, 20 Jul 2021 21:26:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230342AbhGUB0E (ORCPT ); Tue, 20 Jul 2021 21:26:04 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46CFAC061574 for ; Tue, 20 Jul 2021 19:06:40 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id p4-20020a17090a9304b029016f3020d867so129365pjo.3 for ; Tue, 20 Jul 2021 19:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=K5SBha3zR6HnIGPpTHePt7MeaM9Z7zyuvBLYdC04w6M=; b=F/V3TL3EIkA+1SPfKpp4W3wIkSZjEdimZxQlJZaxKweBLdvt7CsRSJQ/QxgTsA08vP Ff3IblbrLlK/KFckX65genz9i8/AG0pZbUyer9R18KnioTwNWwM1jYwvtopwKZrLRC2f OLQRbQcEpEOhmsaN3Ex9d/9KCXsOKFY5qanZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K5SBha3zR6HnIGPpTHePt7MeaM9Z7zyuvBLYdC04w6M=; b=Xro8jatE8oKRFpNywuk0faQMrae9oa326RFZvdgpdBV3LPtfzFk/VVZ5iRY5qzNYi5 3XuyRUpLMueFwD6nlffQEL3asgtONm19hTJQR90FPiGb46cs8VKyq/ZcSBTa3kDNXhom ZEILdEkfyuG5Dz+4O8Fy0gEVgeHtEWN3IzDreCLxOwa7yNSnrCjFgW5IJY7sAOrq8Y+t UPaItoV6nhL469SYJ9+Agl3zenfqoZyKxscM6OwfHCykkKPoiulDzBcX/XTvrGtogaiM YoJi+aimImLaeQl98pnJVYS9pP614MZf91h2UX9rEBfEPr/DqF0hlYKhzFR8Joh7XrGJ psfw== X-Gm-Message-State: AOAM533ijPLmFQcLqXQUA3jgfzX5SYeI7Xro5CGhVfEjZ2enjHlcT+0O 1XoC+f9pxT8NSKIUZhDoKWV/sw== X-Google-Smtp-Source: ABdhPJwo6hl98vCtoCJtqUlnEf/MD/LBM1QEly8wtPd1ZqxMrJU4eNKrvrWI9kd/HRAIwvTyhyDIQQ== X-Received: by 2002:a17:90a:1704:: with SMTP id z4mr1378336pjd.213.1626833199843; Tue, 20 Jul 2021 19:06:39 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:808c:1a13:1159:8184]) by smtp.gmail.com with ESMTPSA id m18sm25367726pfd.42.2021.07.20.19.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 19:06:39 -0700 (PDT) Date: Wed, 21 Jul 2021 11:06:34 +0900 From: Sergey Senozhatsky To: Marc Zyngier Cc: Sergey Senozhatsky , Will Deacon , Suleiman Souhlal , Joel Fernandes , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCHv2 3/4] arm64: do not use dummy vcpu_is_preempted() Message-ID: References: <20210709043713.887098-1-senozhatsky@chromium.org> <20210709043713.887098-4-senozhatsky@chromium.org> <875yxf356w.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875yxf356w.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/07/12 16:47), Marc Zyngier wrote: > > #include > > #include > > +#include > > > > /* See include/linux/spinlock.h */ > > #define smp_mb__after_spinlock() smp_mb() > > > > -/* > > - * Changing this will break osq_lock() thanks to the call inside > > - * smp_cond_load_relaxed(). > > - * > > - * See: > > - * https://lore.kernel.org/lkml/20200110100612.GC2827@hirez.programming.kicks-ass.net > > - */ > > Why are you deleting this? Please explain your reasoning in the commit > message. It seems to me that it still makes complete sense when > CONFIG_PARAVIRT is not defined. You are right. I'll move it to !PARAVIRT #else-branch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39816C12002 for ; Wed, 21 Jul 2021 12:20:10 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id D9E5860D07 for ; Wed, 21 Jul 2021 12:20:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9E5860D07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8CC044B132; Wed, 21 Jul 2021 08:20:09 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@chromium.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zb-6FVxMyZha; Wed, 21 Jul 2021 08:20:08 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1182D4B13C; Wed, 21 Jul 2021 08:20:06 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E07754A483 for ; Tue, 20 Jul 2021 22:06:41 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mPwQhjNYs+dj for ; Tue, 20 Jul 2021 22:06:40 -0400 (EDT) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id C6D184048A for ; Tue, 20 Jul 2021 22:06:40 -0400 (EDT) Received: by mail-pl1-f179.google.com with SMTP id d1so229832plg.0 for ; Tue, 20 Jul 2021 19:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=K5SBha3zR6HnIGPpTHePt7MeaM9Z7zyuvBLYdC04w6M=; b=F/V3TL3EIkA+1SPfKpp4W3wIkSZjEdimZxQlJZaxKweBLdvt7CsRSJQ/QxgTsA08vP Ff3IblbrLlK/KFckX65genz9i8/AG0pZbUyer9R18KnioTwNWwM1jYwvtopwKZrLRC2f OLQRbQcEpEOhmsaN3Ex9d/9KCXsOKFY5qanZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K5SBha3zR6HnIGPpTHePt7MeaM9Z7zyuvBLYdC04w6M=; b=o7VOQFZeKFrNE8ckLxX0bLiw9zyLXLB7++VW6ncJuABzSDh5HqxNrbLEY2NP8t1ez9 wiJup1+bitNL9b5/xVF2igjOaX3o3V78cAWcrQdxzRA7Z4dFLwQGrluRk5KJ+QqSOyt1 lD0D+6czPd+6vnCZ0Q32qdOTKsH0lzrVRzkR/lSALI862aCvCBLgz7OHmUno6I7bxAHX VnAcF6AbCcnxdxqvp59I6apOGa0gZHPb3d+heA4BjW6l02sBOqEKsvvvCJe8zvMo/6OV zPStBe8OSqZo7arIeUjPqJf/kGSW44LwiJseySLcyR45H52OskyffEVhb9NhQYpwcaof AJZg== X-Gm-Message-State: AOAM533dF4WGhQfhkxpL0JbBVC6oapE3NA3PEwnB/mQ4r4S7rzN6ViIp 39DQMEIj84+dWv03ipf98BsUmg== X-Google-Smtp-Source: ABdhPJwo6hl98vCtoCJtqUlnEf/MD/LBM1QEly8wtPd1ZqxMrJU4eNKrvrWI9kd/HRAIwvTyhyDIQQ== X-Received: by 2002:a17:90a:1704:: with SMTP id z4mr1378336pjd.213.1626833199843; Tue, 20 Jul 2021 19:06:39 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:808c:1a13:1159:8184]) by smtp.gmail.com with ESMTPSA id m18sm25367726pfd.42.2021.07.20.19.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 19:06:39 -0700 (PDT) Date: Wed, 21 Jul 2021 11:06:34 +0900 From: Sergey Senozhatsky To: Marc Zyngier Subject: Re: [PATCHv2 3/4] arm64: do not use dummy vcpu_is_preempted() Message-ID: References: <20210709043713.887098-1-senozhatsky@chromium.org> <20210709043713.887098-4-senozhatsky@chromium.org> <875yxf356w.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <875yxf356w.wl-maz@kernel.org> X-Mailman-Approved-At: Wed, 21 Jul 2021 08:20:04 -0400 Cc: Joel Fernandes , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Sergey Senozhatsky , Suleiman Souhlal , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On (21/07/12 16:47), Marc Zyngier wrote: > > #include > > #include > > +#include > > > > /* See include/linux/spinlock.h */ > > #define smp_mb__after_spinlock() smp_mb() > > > > -/* > > - * Changing this will break osq_lock() thanks to the call inside > > - * smp_cond_load_relaxed(). > > - * > > - * See: > > - * https://lore.kernel.org/lkml/20200110100612.GC2827@hirez.programming.kicks-ass.net > > - */ > > Why are you deleting this? Please explain your reasoning in the commit > message. It seems to me that it still makes complete sense when > CONFIG_PARAVIRT is not defined. You are right. I'll move it to !PARAVIRT #else-branch. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A065C07E9B for ; Wed, 21 Jul 2021 02:08:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D43CF6108B for ; Wed, 21 Jul 2021 02:08:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D43CF6108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e7us8y+lj4DtIJHMIPPM9yIpFny+StscPUYQfeiN8J8=; b=E8hvZnV1FShINR yhXKLuw1TUzyRpHz8xavSbNnpXh48RuN3nGRK7sziuLtRB1Xo6ZZ5FH6IF0ihs7oXt++/C73PK6H0 d8ZPPpnSjpkI7ZtT6dobv3FoQ2ePbxVeVKFsj6HhT0WBatL5sKGGQvoMcF1UvnMnpApxM8hGbY1Dn ovYzOwaoGhVrxtqqLZCficcz3hBF429X9ZZgE7SBesNURh/ZyjJNqJShp5HrnKplIYKNvn+mUXaXQ RErks/n8Ukm9XpCjJSaP0YSc6qtb4L2IpC0QQHsoPJQ5o7NKlCTOrpUR4cDpJSBeJfGbdqT/+hZ0Y XH+OJtiRIeZJ8hHTRvkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m61dE-00EHKE-Tj; Wed, 21 Jul 2021 02:06:45 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m61dB-00EHJX-MH for linux-arm-kernel@lists.infradead.org; Wed, 21 Jul 2021 02:06:43 +0000 Received: by mail-pj1-x102f.google.com with SMTP id gp5-20020a17090adf05b0290175c085e7a5so3132288pjb.0 for ; Tue, 20 Jul 2021 19:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=K5SBha3zR6HnIGPpTHePt7MeaM9Z7zyuvBLYdC04w6M=; b=F/V3TL3EIkA+1SPfKpp4W3wIkSZjEdimZxQlJZaxKweBLdvt7CsRSJQ/QxgTsA08vP Ff3IblbrLlK/KFckX65genz9i8/AG0pZbUyer9R18KnioTwNWwM1jYwvtopwKZrLRC2f OLQRbQcEpEOhmsaN3Ex9d/9KCXsOKFY5qanZY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=K5SBha3zR6HnIGPpTHePt7MeaM9Z7zyuvBLYdC04w6M=; b=q7xE17o4ATDn3L4eNA4x7xuF5tvgNP8g/5hvfeejU/lob4MAnNI+bh7amNUGDvi8wF VZw6JLHIPadQY8YR5kZ5yroBZ5y57LjkGLupvZT7iNDBOpNV4WLh0RTyzqekKGU4ey67 /KZIb+Kj47GSWcP/n7cONiXTeK1WBbKYNQ65d6uCX8j20KTHjaFRMTrgbUNKvbzAEWfp xVBrRy+axURHz8CWTjmlAVZkWXJLmr5E2rnNWRRI9fKnIHwXye5NGpCYuIOf+Um49RWw qMI7TUah5CbiRiwKGvP8DeXgOGevCLuRaoSK6ljoQA7gj8LqyCo9LbFazYW6WPw4msMf Iw/w== X-Gm-Message-State: AOAM530GmpdxdCLvIbotf3+00/+ym+yNEyTy/2MF797izK4rETpLnc3q ZF3Lc3nCgGB2auR+i6wWhgHTEA== X-Google-Smtp-Source: ABdhPJwo6hl98vCtoCJtqUlnEf/MD/LBM1QEly8wtPd1ZqxMrJU4eNKrvrWI9kd/HRAIwvTyhyDIQQ== X-Received: by 2002:a17:90a:1704:: with SMTP id z4mr1378336pjd.213.1626833199843; Tue, 20 Jul 2021 19:06:39 -0700 (PDT) Received: from google.com ([2409:10:2e40:5100:808c:1a13:1159:8184]) by smtp.gmail.com with ESMTPSA id m18sm25367726pfd.42.2021.07.20.19.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 19:06:39 -0700 (PDT) Date: Wed, 21 Jul 2021 11:06:34 +0900 From: Sergey Senozhatsky To: Marc Zyngier Cc: Sergey Senozhatsky , Will Deacon , Suleiman Souhlal , Joel Fernandes , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCHv2 3/4] arm64: do not use dummy vcpu_is_preempted() Message-ID: References: <20210709043713.887098-1-senozhatsky@chromium.org> <20210709043713.887098-4-senozhatsky@chromium.org> <875yxf356w.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <875yxf356w.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210720_190641_773359_4792B514 X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On (21/07/12 16:47), Marc Zyngier wrote: > > #include > > #include > > +#include > > > > /* See include/linux/spinlock.h */ > > #define smp_mb__after_spinlock() smp_mb() > > > > -/* > > - * Changing this will break osq_lock() thanks to the call inside > > - * smp_cond_load_relaxed(). > > - * > > - * See: > > - * https://lore.kernel.org/lkml/20200110100612.GC2827@hirez.programming.kicks-ass.net > > - */ > > Why are you deleting this? Please explain your reasoning in the commit > message. It seems to me that it still makes complete sense when > CONFIG_PARAVIRT is not defined. You are right. I'll move it to !PARAVIRT #else-branch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel