From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0631BC6377D for ; Wed, 21 Jul 2021 11:27:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC06560FED for ; Wed, 21 Jul 2021 11:27:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240141AbhGUKqI (ORCPT ); Wed, 21 Jul 2021 06:46:08 -0400 Received: from cloud.peff.net ([104.130.231.41]:53066 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239346AbhGUJyn (ORCPT ); Wed, 21 Jul 2021 05:54:43 -0400 Received: (qmail 2082 invoked by uid 109); 21 Jul 2021 10:34:54 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 21 Jul 2021 10:34:54 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 3288 invoked by uid 111); 21 Jul 2021 10:35:14 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 21 Jul 2021 06:35:14 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 21 Jul 2021 06:35:12 -0400 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, dstolee@microsoft.com, gitster@pobox.com, jonathantanmy@google.com Subject: Re: [PATCH v2 10/24] pack-bitmap.c: introduce 'bitmap_num_objects()' Message-ID: References: <373aa47528ce8bd4bb044a82a7e80312476f1b5f.1624314293.git.me@ttaylorr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <373aa47528ce8bd4bb044a82a7e80312476f1b5f.1624314293.git.me@ttaylorr.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jun 21, 2021 at 06:25:23PM -0400, Taylor Blau wrote: > A subsequent patch to support reading MIDX bitmaps will be less noisy > after extracting a generic function to return how many objects are > contained in a bitmap. Thanks for this. These kinds of preparatory patches make reading the actual tricky changes so much easier. -Peff