From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77824C07E9B for ; Wed, 21 Jul 2021 08:13:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F684611CE for ; Wed, 21 Jul 2021 08:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234560AbhGUHcL (ORCPT ); Wed, 21 Jul 2021 03:32:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:43600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235501AbhGUH1o (ORCPT ); Wed, 21 Jul 2021 03:27:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 00614611C1; Wed, 21 Jul 2021 08:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626854900; bh=CB9OUKQMrgSdC8Z5AXE2cn/p4yiYpa0gBjoMEuRqffc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HiVrrtmvAiAuohqI2l7Tn7FJm4vcjxmuZ9X1+qQ7/6e6AzQx7qWZ2T2/KOrrBA0hw B8Frfv+LuZV9yKlnGt7Zi4/NKFMygi+tLMglSFIxDxUZsDXKZ3leqrClzgLXJ33gTk h7qS4utfoZnMpmlT7gA9VtK1+anrQc3NPbjPAgUU= Date: Wed, 21 Jul 2021 10:08:18 +0200 From: Greg KH To: Claudiu Beznea Cc: stern@rowland.harvard.edu, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, cristian.birsan@microchip.com, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: host: ohci-at91: suspend/resume ports after/before OHCI accesses Message-ID: References: <20210609121027.70951-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210609121027.70951-1-claudiu.beznea@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 09, 2021 at 03:10:27PM +0300, Claudiu Beznea wrote: > On SAMA7G5 suspending ports will cut the access to OHCI registers and > any subsequent access to them will lead to CPU being blocked trying to > access that memory. Same thing happens on resume: if OHCI memory is > accessed before resuming ports the CPU will block on that access. The > OCHI memory is accessed on suspend/resume though > ohci_suspend()/ohci_resume(). > > Signed-off-by: Claudiu Beznea > --- > > The patch was tested on SAMA7G5, SAMA5D2 and SAM9X60. This does not apply to 5.14-rc2, can you please rebase and resend? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0FAC07E9B for ; Wed, 21 Jul 2021 08:09:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42637611C1 for ; Wed, 21 Jul 2021 08:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42637611C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7fjeWnyWlGRDxh/3CTkvaL2z7CQbv4XpMouLSmvBJE0=; b=oxJ6vI+ko9ksf3 WFg5QA7KlN+pmE27ZL/GJLormJ3n10LOzffQfAbqhXIKa8192AXBfco165aNoN7Wl0CDrjEYgelOo cnZyXLhlRHy8iDqjgo9xtGIOfQveb3IohDt9IYgdw6/cVrKRWewgFQVy2shZzlWgJ1/zEyYR2rTtL U79xcAqcC7JtgvrXAOr6sgsAyyh5uLSGbeWP48HU3vueAYxIRe3bWKPMiSMbhFqzgyXDhH4PumMJ0 BKw/Ov5hwBMEpttnj8o+r6tE6n1OAPRqqRaS0AvO40pNegBW0nw8DYAO5euCCnnf1nab5c2cMkkjq 6zroWd0WUtCuCl2WZPOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m67HD-00Epen-S6; Wed, 21 Jul 2021 08:08:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m67HA-00Epe7-Ue for linux-arm-kernel@lists.infradead.org; Wed, 21 Jul 2021 08:08:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 00614611C1; Wed, 21 Jul 2021 08:08:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626854900; bh=CB9OUKQMrgSdC8Z5AXE2cn/p4yiYpa0gBjoMEuRqffc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HiVrrtmvAiAuohqI2l7Tn7FJm4vcjxmuZ9X1+qQ7/6e6AzQx7qWZ2T2/KOrrBA0hw B8Frfv+LuZV9yKlnGt7Zi4/NKFMygi+tLMglSFIxDxUZsDXKZ3leqrClzgLXJ33gTk h7qS4utfoZnMpmlT7gA9VtK1+anrQc3NPbjPAgUU= Date: Wed, 21 Jul 2021 10:08:18 +0200 From: Greg KH To: Claudiu Beznea Subject: Re: [PATCH] usb: host: ohci-at91: suspend/resume ports after/before OHCI accesses Message-ID: References: <20210609121027.70951-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210609121027.70951-1-claudiu.beznea@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_010821_075687_6CF70FE5 X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, stern@rowland.harvard.edu, linux-arm-kernel@lists.infradead.org, cristian.birsan@microchip.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 09, 2021 at 03:10:27PM +0300, Claudiu Beznea wrote: > On SAMA7G5 suspending ports will cut the access to OHCI registers and > any subsequent access to them will lead to CPU being blocked trying to > access that memory. Same thing happens on resume: if OHCI memory is > accessed before resuming ports the CPU will block on that access. The > OCHI memory is accessed on suspend/resume though > ohci_suspend()/ohci_resume(). > > Signed-off-by: Claudiu Beznea > --- > > The patch was tested on SAMA7G5, SAMA5D2 and SAM9X60. This does not apply to 5.14-rc2, can you please rebase and resend? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel