All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Phillip Potter <phil@philpotter.co.uk>
Cc: Larry.Finger@lwfinger.net, dan.carpenter@oracle.com,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory
Date: Wed, 21 Jul 2021 10:16:14 +0200	[thread overview]
Message-ID: <YPfXzlmYk4EPap+F@kroah.com> (raw)
In-Reply-To: <20210719224601.255364-1-phil@philpotter.co.uk>

On Mon, Jul 19, 2021 at 11:46:01PM +0100, Phillip Potter wrote:
> Move all C source files from the core subdirectory to the root
> folder of the driver, and adjust Makefile accordingly. The ultmate
> goal is to remove hal layer and fold its functionalty into the main
> sources. At this point, the distinction between hal and core will be
> meaningless, so this is the first step towards simplifying the file
> layout.
> 
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
>  drivers/staging/rtl8188eu/Makefile            | 34 +++++++++----------
>  drivers/staging/rtl8188eu/{core => }/rtw_ap.c |  0

<snip>

As others have pointed out, let's move files when they need to be moved,
not yet.  Removing the HAL layer is great here, but when that happens,
the hal/ directory will be empty and we can go from there if things
still need to be moved.

thanks,

greg k-h

      parent reply	other threads:[~2021-07-21  8:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19 22:46 [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory Phillip Potter
2021-07-19 23:46 ` Larry Finger
2021-07-20  9:00   ` Fabio Aiuto
2021-07-20 22:54     ` Phillip Potter
2021-07-21  7:51       ` Fabio Aiuto
2021-07-21  0:22     ` Larry Finger
2021-07-21  7:47       ` Fabio Aiuto
2021-07-21  7:49       ` Phillip Potter
2021-07-21 17:33         ` Larry Finger
2021-07-21 18:28           ` Dan Carpenter
2021-07-21 19:18             ` Larry Finger
2021-07-22 10:44               ` Phillip Potter
2021-07-22 10:44                 ` Phillip Potter
2021-07-22 13:28                 ` Greg KH
2021-07-22 16:30                   ` Larry Finger
2021-07-22 22:12                     ` Phillip Potter
2021-07-22 22:12                       ` Phillip Potter
2021-07-20 22:51   ` Phillip Potter
2021-07-21  8:16 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPfXzlmYk4EPap+F@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.