From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EBE1C636C9 for ; Wed, 21 Jul 2021 19:53:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59D8E6124C for ; Wed, 21 Jul 2021 19:53:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239940AbhGUTMl (ORCPT ); Wed, 21 Jul 2021 15:12:41 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38996 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238276AbhGUTMk (ORCPT ); Wed, 21 Jul 2021 15:12:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=casm0fBJN/w1gZgDxRShD84HThb0ogBtG634HmnOurQ=; b=bL5qYm8tX3U43g+EGgU4AHaYRh tWkV82c+7AVniUnYgQcSRTug7fhvl1J5ozeeviKzpjNaWUQ+9cUZeNxLM706lfZPGb8Z/c93NdjJr sA02T2KF+6JEwR5v2U6YAMphhRThZ5R/wzmOXXNU1mR7I3cWgYKw0RxSvlkCpmzGCjhA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m6IHJ-00EFMq-7P; Wed, 21 Jul 2021 21:53:13 +0200 Date: Wed, 21 Jul 2021 21:53:13 +0200 From: Andrew Lunn To: Sasha Neftin Cc: Tony Nguyen , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, vitaly.lifshits@intel.com, Dvora Fuxbrumer Subject: Re: [PATCH net-next 09/12] igc: Remove _I_PHY_ID checking Message-ID: References: <20210720232101.3087589-1-anthony.l.nguyen@intel.com> <20210720232101.3087589-10-anthony.l.nguyen@intel.com> <6cb7fbe9-35e2-8fb1-11fa-cbd6ce01bab2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6cb7fbe9-35e2-8fb1-11fa-cbd6ce01bab2@intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jul 21, 2021 at 09:02:13PM +0300, Sasha Neftin wrote: > On 7/21/2021 17:50, Andrew Lunn wrote: > > On Tue, Jul 20, 2021 at 04:20:58PM -0700, Tony Nguyen wrote: > > > From: Sasha Neftin > > > > > > i225 devices have only one PHY vendor. There is no point checking > > > _I_PHY_ID during the link establishment and auto-negotiation process. > > > This patch comes to clean up these pointless checkings. > > > > I don't know this hardware.... > > > > Is the PHY integrated into the MAC? Or is it external? > i225 controller offers a fully-integrated Media Access Control > (MAC) and Physical Layer (PHY) port. > Both components (MAC and PHY) supports 2.5G Hi Sasha Thanks for the info. Then this change make sense. But the commit message could of been better. It is not really about there being one PHY vendor, it is simply impossible for the PHY to be anything else, so there is no need to check. Andrew