From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31678C63793 for ; Thu, 22 Jul 2021 08:08:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6D1861289 for ; Thu, 22 Jul 2021 08:08:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6D1861289 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=NetBSD.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Tl2-0000bK-Do for qemu-devel@archiver.kernel.org; Thu, 22 Jul 2021 04:08:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6Th7-0006cf-LB for qemu-devel@nongnu.org; Thu, 22 Jul 2021 04:04:38 -0400 Received: from 13thmonkey.org ([80.100.255.32]:61694 helo=dropje.13thmonkey.org) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Th5-0008B0-DD for qemu-devel@nongnu.org; Thu, 22 Jul 2021 04:04:36 -0400 Received: by dropje.13thmonkey.org (Postfix, from userid 103) id 75A08C1EEA6; Thu, 22 Jul 2021 10:04:32 +0200 (CEST) Date: Thu, 22 Jul 2021 10:04:32 +0200 From: Reinoud Zandijk To: Markus Armbruster Subject: Re: [PATCH 08/16] whpx nvmm: Drop useless migrate_del_blocker() Message-ID: References: <20210720125408.387910-1-armbru@redhat.com> <20210720125408.387910-9-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720125408.387910-9-armbru@redhat.com> Received-SPF: pass client-ip=80.100.255.32; envelope-from=reinoud@13thmonkey.org; helo=dropje.13thmonkey.org X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sunil Muthuswamy , Kamil Rytarowski , Reinoud Zandijk , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 20, 2021 at 02:54:00PM +0200, Markus Armbruster wrote: > There is nothing to delete after migrate_add_blocker() failed. Trying > anyway is safe, but useless. Don't. > > Cc: Sunil Muthuswamy > Cc: Kamil Rytarowski > Cc: Reinoud Zandijk > Signed-off-by: Markus Armbruster > --- > target/i386/nvmm/nvmm-all.c | 1 - > target/i386/whpx/whpx-all.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c > index dfa690d65d..7bb0d9e30e 100644 > --- a/target/i386/nvmm/nvmm-all.c > +++ b/target/i386/nvmm/nvmm-all.c > @@ -929,7 +929,6 @@ nvmm_init_vcpu(CPUState *cpu) > (void)migrate_add_blocker(nvmm_migration_blocker, &local_error); > if (local_error) { > error_report_err(local_error); > - migrate_del_blocker(nvmm_migration_blocker); > error_free(nvmm_migration_blocker); > return -EINVAL; > } Reviewed-by: Reinoud Zandijk No problem with it