From: Anthony PERARD via <qemu-devel@nongnu.org> To: Jason Andryuk <jandryuk@gmail.com> Cc: <pbonzini@redhat.com>, <qemu-devel@nongnu.org>, <xen-devel@lists.xenproject.org> Subject: Re: [PATCH] vl: Parse legacy default_machine_opts Date: Thu, 22 Jul 2021 15:12:33 +0100 [thread overview] Message-ID: <YPl80YnsDpLI8gtN@perard> (raw) In-Reply-To: <20210713021552.19110-1-jandryuk@gmail.com> On Mon, Jul 12, 2021 at 10:15:52PM -0400, Jason Andryuk wrote: > qemu can't start a xen vm after commit d8fb7d0969d5 > "vl: switch -M parsing to keyval" with: > > $ ./qemu-system-i386 -M xenfv > Unexpected error in object_property_find_err() at ../qom/object.c:1298: > qemu-system-i386: Property 'xenfv-3.1-machine.accel' not found > Aborted (core dumped) > > The default_machine_opts handling doesn't process the legacy machine > options like "accel". Call qemu_apply_legacy_machine_options to provide > the legacy handling. > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> I can't find a different way to set a default "accelerator" to a machine, so this patch seems necessary. Thanks, > --- > softmmu/vl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/softmmu/vl.c b/softmmu/vl.c > index 4df1496101..f4d8630fc6 100644 > --- a/softmmu/vl.c > +++ b/softmmu/vl.c > @@ -2126,6 +2126,7 @@ static void qemu_create_machine(QDict *qdict) > QDict *default_opts = > keyval_parse(machine_class->default_machine_opts, NULL, NULL, > &error_abort); > + qemu_apply_legacy_machine_options(default_opts); > object_set_properties_from_keyval(OBJECT(current_machine), default_opts, > false, &error_abort); > qobject_unref(default_opts); -- Anthony PERARD
WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com> To: Jason Andryuk <jandryuk@gmail.com> Cc: <pbonzini@redhat.com>, <qemu-devel@nongnu.org>, <xen-devel@lists.xenproject.org> Subject: Re: [PATCH] vl: Parse legacy default_machine_opts Date: Thu, 22 Jul 2021 15:12:33 +0100 [thread overview] Message-ID: <YPl80YnsDpLI8gtN@perard> (raw) In-Reply-To: <20210713021552.19110-1-jandryuk@gmail.com> On Mon, Jul 12, 2021 at 10:15:52PM -0400, Jason Andryuk wrote: > qemu can't start a xen vm after commit d8fb7d0969d5 > "vl: switch -M parsing to keyval" with: > > $ ./qemu-system-i386 -M xenfv > Unexpected error in object_property_find_err() at ../qom/object.c:1298: > qemu-system-i386: Property 'xenfv-3.1-machine.accel' not found > Aborted (core dumped) > > The default_machine_opts handling doesn't process the legacy machine > options like "accel". Call qemu_apply_legacy_machine_options to provide > the legacy handling. > > Signed-off-by: Jason Andryuk <jandryuk@gmail.com> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> I can't find a different way to set a default "accelerator" to a machine, so this patch seems necessary. Thanks, > --- > softmmu/vl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/softmmu/vl.c b/softmmu/vl.c > index 4df1496101..f4d8630fc6 100644 > --- a/softmmu/vl.c > +++ b/softmmu/vl.c > @@ -2126,6 +2126,7 @@ static void qemu_create_machine(QDict *qdict) > QDict *default_opts = > keyval_parse(machine_class->default_machine_opts, NULL, NULL, > &error_abort); > + qemu_apply_legacy_machine_options(default_opts); > object_set_properties_from_keyval(OBJECT(current_machine), default_opts, > false, &error_abort); > qobject_unref(default_opts); -- Anthony PERARD
next prev parent reply other threads:[~2021-07-22 14:17 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-06 10:01 [PULL 00/40] Misc patches for 2021-07-06 Paolo Bonzini 2021-07-06 10:01 ` [PULL 01/40] Makefile: Remove /usr/bin/env wrapper from the SHELL variable Paolo Bonzini 2021-07-06 10:01 ` [PULL 02/40] softmmu/vl: Remove obsolete comment about the "frame" parameter Paolo Bonzini 2021-07-06 10:01 ` [PULL 03/40] ui: Fix the "-display sdl,window_close=..." parameter Paolo Bonzini 2021-07-06 10:01 ` [PULL 04/40] ui: Mark the '-no-quit' option as deprecated Paolo Bonzini 2021-07-06 10:01 ` [PULL 05/40] qemu-options: Improve the documentation of the -display options Paolo Bonzini 2021-07-06 10:01 ` [PULL 06/40] coverity-scan: Remove lm32 / unicore32 targets Paolo Bonzini 2021-07-06 10:01 ` [PULL 07/40] coverity-scan: switch to vpath build Paolo Bonzini 2021-07-06 10:01 ` [PULL 08/40] target/i386: Declare constants for XSAVE offsets Paolo Bonzini 2021-07-06 10:01 ` [PULL 09/40] target/i386: Consolidate the X86XSaveArea offset checks Paolo Bonzini 2021-07-06 10:01 ` [PULL 10/40] target/i386: Clarify the padding requirements of X86XSaveArea Paolo Bonzini 2021-07-06 10:01 ` [PULL 11/40] target/i386: Pass buffer and length to XSAVE helper Paolo Bonzini 2021-07-06 10:01 ` [PULL 12/40] target/i386: Make x86_ext_save_areas visible outside cpu.c Paolo Bonzini 2021-07-06 10:01 ` [PULL 13/40] target/i386: Observe XSAVE state area offsets Paolo Bonzini 2021-07-06 10:01 ` [PULL 14/40] target/i386: Populate x86_ext_save_areas offsets using cpuid where possible Paolo Bonzini 2021-07-06 10:01 ` [PULL 15/40] target/i386: Move X86XSaveArea into TCG Paolo Bonzini 2021-07-06 10:01 ` [PULL 16/40] configure: drop vte-2.90 check Paolo Bonzini 2021-07-06 10:01 ` [PULL 17/40] configure, meson: convert vte detection to meson Paolo Bonzini 2021-07-06 10:01 ` [PULL 18/40] configure, meson: convert virgl " Paolo Bonzini 2021-07-06 10:01 ` [PULL 19/40] configure, meson: convert libdaxctl " Paolo Bonzini 2021-07-06 10:01 ` [PULL 20/40] configure, meson: convert libpmem " Paolo Bonzini 2021-07-06 10:01 ` [PULL 21/40] configure, meson: convert liburing " Paolo Bonzini 2021-07-06 10:01 ` [PULL 22/40] configure, meson: convert libxml2 " Paolo Bonzini 2021-07-06 10:01 ` [PULL 23/40] meson: sort existing compiler tests Paolo Bonzini 2021-07-06 10:01 ` [PULL 24/40] meson: store dependency('threads') in a variable Paolo Bonzini 2021-07-06 10:01 ` [PULL 25/40] configure, meson: move CONFIG_IVSHMEM to meson Paolo Bonzini 2021-07-06 10:01 ` [PULL 26/40] configure: convert HAVE_BROKEN_SIZE_MAX " Paolo Bonzini 2021-07-06 10:01 ` [PULL 27/40] configure: convert compiler tests to meson, part 1 Paolo Bonzini 2021-07-06 10:01 ` [PULL 28/40] configure: convert compiler tests to meson, part 2 Paolo Bonzini 2021-07-06 10:01 ` [PULL 29/40] configure: convert compiler tests to meson, part 3 Paolo Bonzini 2021-07-06 10:01 ` [PULL 30/40] configure: convert compiler tests to meson, part 4 Paolo Bonzini 2021-07-06 10:01 ` [PULL 31/40] configure: convert compiler tests to meson, part 5 Paolo Bonzini 2021-07-06 10:01 ` [PULL 32/40] configure: convert compiler tests to meson, part 6 Paolo Bonzini 2021-07-06 10:01 ` [PULL 33/40] qom: export more functions for use with non-UserCreatable objects Paolo Bonzini 2021-07-06 10:01 ` [PULL 34/40] keyval: introduce keyval_merge Paolo Bonzini 2021-07-06 10:01 ` [PULL 35/40] keyval: introduce keyval_parse_into Paolo Bonzini 2021-07-06 10:01 ` [PULL 36/40] vl: switch -M parsing to keyval Paolo Bonzini 2021-07-08 16:31 ` Jason Andryuk 2021-07-08 16:31 ` Jason Andryuk 2021-07-13 2:15 ` [PATCH] vl: Parse legacy default_machine_opts Jason Andryuk 2021-07-22 14:12 ` Anthony PERARD via [this message] 2021-07-22 14:12 ` Anthony PERARD 2021-07-22 14:39 ` Paolo Bonzini 2021-07-22 14:39 ` Paolo Bonzini 2021-07-12 19:24 ` [PULL 36/40] vl: switch -M parsing to keyval Volker Rümelin 2021-07-13 19:43 ` Alex Williamson 2021-07-13 23:10 ` Alex Williamson 2021-07-14 6:16 ` Mark Cave-Ayland 2021-07-14 22:13 ` Alex Williamson 2021-07-22 8:19 ` Peter Krempa 2021-07-22 14:39 ` Paolo Bonzini 2021-07-22 14:50 ` Peter Krempa 2021-07-06 10:01 ` [PULL 37/40] machine: add smp compound property Paolo Bonzini 2021-07-13 10:37 ` Peter Maydell 2021-07-13 11:07 ` Markus Armbruster 2021-07-13 10:53 ` Peter Maydell 2021-07-06 10:01 ` [PULL 38/40] qemu-option: remove now-dead code Paolo Bonzini 2021-07-06 10:01 ` [PULL 39/40] Set icon for QEMU binary on Mac OS Paolo Bonzini 2021-07-06 10:01 ` [PULL 40/40] config-host.mak: remove unused compiler-related lines Paolo Bonzini 2021-07-06 12:10 ` [PULL 00/40] Misc patches for 2021-07-06 Peter Maydell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YPl80YnsDpLI8gtN@perard \ --to=qemu-devel@nongnu.org \ --cc=anthony.perard@citrix.com \ --cc=jandryuk@gmail.com \ --cc=pbonzini@redhat.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.