From: Taylor Blau <me@ttaylorr.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>,
Emily Shaffer <emilyshaffer@google.com>,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: What's cooking in git.git (Jul 2021, #05; Wed, 21)
Date: Thu, 22 Jul 2021 10:16:49 -0400 [thread overview]
Message-ID: <YPl90eSyuovU3CvT@nand.local> (raw)
In-Reply-To: <87a6mevkrx.fsf@evledraar.gmail.com>
On Thu, Jul 22, 2021 at 09:33:39AM +0200, Ævar Arnfjörð Bjarmason wrote:
> > * ab/pack-stdin-packs-fix (2021-07-09) 2 commits
> > - pack-objects: fix segfault in --stdin-packs option
> > - pack-objects tests: cover blindspots in stdin handling
> >
> > Input validation of "git pack-objects --stdin-packs" has been
> > corrected.
> >
> > Ack?
> > cf. <YND3h2l10PlnSNGJ@nand.local>
>
> Have re-rolled & addressed that, I think
> https://lore.kernel.org/git/YPcA0oxJgedIf57K@nand.local/ can be read as
> "sure, let's take Ævar's v2 as-is", but let's have Taylor Ack that :)
Like I said in the thread, I don't mind what you wrote (so you can take
that as an ACK from me that I wouldn't be sad to see it get picked up),
but I do think what I suggested makes the test easier to write.
I don't care enough to worry too much about it, so if you're not
interested in polishing it further, then what you have is fine by me.
Thanks,
Taylor
next prev parent reply other threads:[~2021-07-22 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 2:27 What's cooking in git.git (Jul 2021, #05; Wed, 21) Junio C Hamano
2021-07-22 7:33 ` Ævar Arnfjörð Bjarmason
2021-07-22 14:16 ` Taylor Blau [this message]
2021-07-22 22:37 ` Junio C Hamano
2021-07-23 7:32 ` Ævar Arnfjörð Bjarmason
2021-07-23 16:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPl90eSyuovU3CvT@nand.local \
--to=me@ttaylorr.com \
--cc=avarab@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.