From: "Theodore Ts'o" <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
Qu Wenruo <quwenruo.btrfs@gmx.com>,
Eryu Guan <eguan@linux.alibaba.com>, Qu Wenruo <wqu@suse.com>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH RFC] fstests: allow running custom hooks
Date: Thu, 22 Jul 2021 10:41:29 -0400 [thread overview]
Message-ID: <YPmDmZL6oLnGhayx@mit.edu> (raw)
In-Reply-To: <20210721232830.GC2112234@dread.disaster.area>
On Thu, Jul 22, 2021 at 09:28:30AM +1000, Dave Chinner wrote:
>
> I'm thinking that it is something relatively simple like this:
>
> fstests/tests/hooks
> - directory containing library of hook scripts
I'd suggest fstests/common/hooks instead, since the hook scripts
aren't actually *tests* per so, but rather utility scripts, and common
would be a better place for it, I think.
> fstests/hooks/
> - directory containing symlinks to hook scripts
This might be a good default, but it might be better if the location
of the hook directory could be overridden via an environment variable.
In some cases, instead of having run-time configuration inside the
fstests directtory with .gitignore, it might be more convenient for it
if were made available externally (for example, via a 9p file system
in a case where tests are being run via KVM using a rootfs test image
with qmeu's snapshot mode so the hook directory could be supplied from
the host).
- Ted
next prev parent reply other threads:[~2021-07-22 14:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 7:13 [PATCH RFC] fstests: allow running custom hooks Qu Wenruo
2021-07-19 14:02 ` Theodore Y. Ts'o
2021-07-19 22:06 ` Qu Wenruo
2021-07-20 0:43 ` Theodore Y. Ts'o
2021-07-20 0:50 ` Qu Wenruo
2021-07-20 4:05 ` Eryu Guan
2021-07-20 0:25 ` Dave Chinner
2021-07-20 0:36 ` Qu Wenruo
2021-07-20 2:14 ` Dave Chinner
2021-07-20 2:45 ` Qu Wenruo
2021-07-20 6:43 ` Dave Chinner
2021-07-20 7:26 ` Qu Wenruo
2021-07-20 7:57 ` Eryu Guan
2021-07-20 8:29 ` Qu Wenruo
2021-07-20 8:44 ` Qu Wenruo
2021-07-20 15:38 ` Theodore Y. Ts'o
2021-07-20 22:34 ` Qu Wenruo
2021-07-21 1:11 ` Dave Chinner
2021-07-21 1:52 ` Qu Wenruo
2021-07-21 2:23 ` Damien Le Moal
2021-07-21 2:57 ` Qu Wenruo
2021-07-21 23:28 ` Dave Chinner
2021-07-22 14:41 ` Theodore Ts'o [this message]
2021-07-22 22:21 ` Dave Chinner
2021-07-23 3:30 ` Theodore Ts'o
2021-07-23 4:32 ` Eryu Guan
2021-07-20 1:16 ` Darrick J. Wong
2021-07-20 1:24 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPmDmZL6oLnGhayx@mit.edu \
--to=tytso@mit.edu \
--cc=Damien.LeMoal@wdc.com \
--cc=david@fromorbit.com \
--cc=eguan@linux.alibaba.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.