From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F90C6379B for ; Thu, 22 Jul 2021 15:11:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9565D6128D for ; Thu, 22 Jul 2021 15:11:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232619AbhGVOal (ORCPT ); Thu, 22 Jul 2021 10:30:41 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40594 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232579AbhGVOaL (ORCPT ); Thu, 22 Jul 2021 10:30:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ajej3+irDqRdJgoNF2/l9QhKv78ek+8OVhoEERA6Psk=; b=aR3Xi+fgdmQ6dui1iOXYVoCdRe 2uLOcSC4BoCvooLc39uGnbJRc0y15aK/e3xMGcYIhgzVrFoF0Y7bo8AS5efJUKHxA229nkD5XKSw6 2nkrVT/vjNgZqx5QtHi+5/7r7vAXvJwyf8oZO5ZMnaDajbgh8QR3p5kmDHJTlwFhVt/k=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m6aLG-00ELYG-CI; Thu, 22 Jul 2021 17:10:30 +0200 Date: Thu, 22 Jul 2021 17:10:30 +0200 From: Andrew Lunn To: Ioana Ciornei Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, corbet@lwn.net, Ioana Ciornei Subject: Re: [PATCH net-next] docs: networking: dpaa2: add documentation for the switch driver Message-ID: References: <20210722132735.685606-1-ciorneiioana@gmail.com> <20210722144258.iir7cgowfplwzjlq@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722144258.iir7cgowfplwzjlq@skbuf> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > Are these requirements tested? Will the driver fail probe if they are > > not met? > > Yes, they are tested. > > If the DPSW object configuration does not meet the requirements, the > driver will error out on probe with a message explictly saying what > is happening. Good. Maybe reference that here, so somebody googling the error message lands on this document. > On the other hand, I think this section might give too much details on > the actual implementation (I took it from the commit message of the > patch adding the support). Might as well just remove it and add the > example. > > All that I was trying to say is that the filters will not be added in > the ACL table with the explicit priority specified by the user but > rather with one determined based on all the rules currently present in > the table. > Nothing is unusual in the usage, the order in which the rules are > executed will be respected. So if it is an implementation detail, it probably is not relevant here. Andrew