From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16BA7C63799 for ; Thu, 22 Jul 2021 16:59:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 021B96052B for ; Thu, 22 Jul 2021 16:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235228AbhGVQSe (ORCPT ); Thu, 22 Jul 2021 12:18:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235123AbhGVQRR (ORCPT ); Thu, 22 Jul 2021 12:17:17 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 061E5C0617A1; Thu, 22 Jul 2021 09:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fY1GU33NdlDCFwWGiRlEzVzzUv/E61mi0egIUEebmpo=; b=F5eMUIgNSgTJAoMmkWgV7WEaGk SyNUL6h+5z5WIgAKB5tCR1lkqGE3SxjCuK5WMPc8OMeVu+eRh6kAWuAa9nw9xl+4hE1AG6ioLCA3E nsKtOKkZ0LrfrTD3baDwTn9nGp0WrYzQ6fmaUjEBIX7+Y63IU2TbEdFB6iT6hXmBUq+1s0Fw9ig5B nGN36cEvC0sYRIGb9q0I80Y3l2Fx0ZCabOKq4WDAzLvquEO8JwXD4UmOQsp1f8aMGNWyeGtF/g+iD 03p2q4UXX9Pr84W+9WN75zicYa5nvTQEPOxczUrjSBFOTt1MixsMTewOzxUvEDbPmCMIPW8zWvoqP DNYGIM0g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6c0Q-00AUeF-Ty; Thu, 22 Jul 2021 16:57:16 +0000 Date: Thu, 22 Jul 2021 17:57:06 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: "Darrick J. Wong" , Gao Xiang , linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, LKML , Andreas Gruenbacher Subject: Re: [PATCH v6] iomap: support tail packing inline read Message-ID: References: <20210722031729.51628-1-hsiangkao@linux.alibaba.com> <20210722053947.GA28594@lst.de> <20210722165109.GD8639@magnolia> <20210722165342.GA11435@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722165342.GA11435@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 22, 2021 at 06:53:42PM +0200, Christoph Hellwig wrote: > On Thu, Jul 22, 2021 at 09:51:09AM -0700, Darrick J. Wong wrote: > > The commit message is a little misleading -- this adds support for > > inline data pages at nonzero (but page-aligned) file offsets, not file > > offsets into the page itself. I suggest: > > It actually adds both. pos is the offset into the file. If you want to add support for both, then you need to call iomap_set_range_uptodate() instead of SetPageUptodate(). Otherwise, you can set the page uptodate before submitting the bio for the first half of the page. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B3DC63793 for ; Thu, 22 Jul 2021 16:58:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E2D661241 for ; Thu, 22 Jul 2021 16:58:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E2D661241 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GVzCt223jz302J for ; Fri, 23 Jul 2021 02:58:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=F5eMUIgN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2001:8b0:10b:1236::1; helo=casper.infradead.org; envelope-from=willy@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=casper.20170209 header.b=F5eMUIgN; dkim-atps=neutral Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GVzCk44Qgz2yNw for ; Fri, 23 Jul 2021 02:57:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fY1GU33NdlDCFwWGiRlEzVzzUv/E61mi0egIUEebmpo=; b=F5eMUIgNSgTJAoMmkWgV7WEaGk SyNUL6h+5z5WIgAKB5tCR1lkqGE3SxjCuK5WMPc8OMeVu+eRh6kAWuAa9nw9xl+4hE1AG6ioLCA3E nsKtOKkZ0LrfrTD3baDwTn9nGp0WrYzQ6fmaUjEBIX7+Y63IU2TbEdFB6iT6hXmBUq+1s0Fw9ig5B nGN36cEvC0sYRIGb9q0I80Y3l2Fx0ZCabOKq4WDAzLvquEO8JwXD4UmOQsp1f8aMGNWyeGtF/g+iD 03p2q4UXX9Pr84W+9WN75zicYa5nvTQEPOxczUrjSBFOTt1MixsMTewOzxUvEDbPmCMIPW8zWvoqP DNYGIM0g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6c0Q-00AUeF-Ty; Thu, 22 Jul 2021 16:57:16 +0000 Date: Thu, 22 Jul 2021 17:57:06 +0100 From: Matthew Wilcox To: Christoph Hellwig Subject: Re: [PATCH v6] iomap: support tail packing inline read Message-ID: References: <20210722031729.51628-1-hsiangkao@linux.alibaba.com> <20210722053947.GA28594@lst.de> <20210722165109.GD8639@magnolia> <20210722165342.GA11435@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722165342.GA11435@lst.de> X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Darrick J. Wong" , Andreas Gruenbacher , LKML , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Thu, Jul 22, 2021 at 06:53:42PM +0200, Christoph Hellwig wrote: > On Thu, Jul 22, 2021 at 09:51:09AM -0700, Darrick J. Wong wrote: > > The commit message is a little misleading -- this adds support for > > inline data pages at nonzero (but page-aligned) file offsets, not file > > offsets into the page itself. I suggest: > > It actually adds both. pos is the offset into the file. If you want to add support for both, then you need to call iomap_set_range_uptodate() instead of SetPageUptodate(). Otherwise, you can set the page uptodate before submitting the bio for the first half of the page.