All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Bobrowski <repnop@google.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [bug report] fanotify: fix copy_event_to_user() fid error clean up
Date: Fri, 23 Jul 2021 09:13:28 +1000	[thread overview]
Message-ID: <YPn7mCNt33rFWjhD@google.com> (raw)
In-Reply-To: <20210722140103.GZ25548@kadam>

On Thu, Jul 22, 2021 at 05:01:03PM +0300, Dan Carpenter wrote:
> On Thu, Jul 22, 2021 at 12:31:42PM +0300, Dan Carpenter wrote:
> > Smatch is *supposed* to know about the relationship between those two.
> > The bug is actually that Smatch records in the database that create_fd()
> > always fails.  It's a serious bug, and I'm trying to investigate what's
> > going on and I'm sure that I will fix this before the end of the week.
> 
> I'm testing a Smatch fix for this so hopefully it will pushed in a few
> days.

Great!

Well, do let us know what the outcome is post running the Smatch tests
against the copy_event_to_user() function once again...

I do feel as though shuffling things around isn't necessary. Especially
considering the fact that what is current is correct and as you mentioned
this is a perfect oppurtunity to make the tooling better. :)

/M

      reply	other threads:[~2021-07-22 23:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 12:54 [bug report] fanotify: fix copy_event_to_user() fid error clean up Dan Carpenter
2021-07-21 22:38 ` Matthew Bobrowski
2021-07-22  9:01   ` Amir Goldstein
2021-07-22  9:31     ` Dan Carpenter
2021-07-22 14:01       ` Dan Carpenter
2021-07-22 23:13         ` Matthew Bobrowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPn7mCNt33rFWjhD@google.com \
    --to=repnop@google.com \
    --cc=amir73il@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.