Re: [PATCH v3 5/5] Makefile: normalize clobbering & xargs for tags targets

From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Denton Liu <liu.denton@gmail.com>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Kristof Provost <Kristof@provost-engineering.be>,
	Taylor Blau <me@ttaylorr.com>,
	Ramsay Jones <ramsay@ramsayjones.plus.com>
Subject: Re: [PATCH v3 5/5] Makefile: normalize clobbering & xargs for tags targets
Date: Fri, 23 Jul 2021 06:47:50 -0400	[thread overview]
Message-ID: <YPqeVnoC3mL1t8/a@coredump.intra.peff.net> (raw)
In-Reply-To: <YPqdQZdfR1kh0vGT@coredump.intra.peff.net>

On Fri, Jul 23, 2021 at 06:43:13AM -0400, Jeff King wrote:

> On Thu, Jul 22, 2021 at 01:23:06AM +0200, Ævar Arnfjörð Bjarmason wrote:
> 
> > This is because the xargs command may decide to invoke the program
> > multiple times. We need to make sure we've got a union of its results
> > at the end.
> > 
> > For "ctags" and "etags" we used the "-a" flag for this, for cscope
> > that behavior is the default. Its "-u" flag disables its equivalent of
> > an implicit "-a" flag.
> 
> Hrm, that's not the experience I get with cscope. E.g.:

Just to make it extra clear: this is not a problem introduced by your
series, since we were already using xargs with cscope. But this seems
like a good time to fix it.

-Peff