From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B91FC4320A for ; Fri, 23 Jul 2021 14:24:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 607C560EBC for ; Fri, 23 Jul 2021 14:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235274AbhGWNnq (ORCPT ); Fri, 23 Jul 2021 09:43:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233666AbhGWNnq (ORCPT ); Fri, 23 Jul 2021 09:43:46 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB46FC061757 for ; Fri, 23 Jul 2021 07:24:18 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id i39-20020a9d17270000b02904cf73f54f4bso339991ota.2 for ; Fri, 23 Jul 2021 07:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TFOUkgVe/De3oymeenLBuNPer+TUmPN7lpMy3blENNw=; b=kMYc3VLcZ8HQkeGDP4GCj08ozIhO820sv8drLzH/p0tt+jnIl+jqN4ig75T2p0lKw/ GbMiV85J/nc0wqsoDrAy0FBoq8f4oWdxggAf3+1YZZPlqb/CIQw5PVwLqx2g1fKTU/xJ 2zCvCUTIqjmHIwMlzDo3Cq42Eirw6Z6bccTo6dTdRcjCoYtQKxDXrejsuVsuSV7LCRQR tuD974zCr28piclys4fQ7Y+lvwA+YYLmvDQ7giWULxqVOoa7Wshd7pAgkk+NcwkU53VM XgANK5fQb4M+ZZKMo9j6bpevRaDl4Dkyn+6PvhDQZiXVmnZmgWeY7qgorQkOPqWuAEcY HFBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TFOUkgVe/De3oymeenLBuNPer+TUmPN7lpMy3blENNw=; b=HCe5P8qvrcs6IDBeFrVpWNTst/kX25DrObcpM2nRCDaHkINEfrnDKRK47SENg50qtr mLjBP76hsm3eM8dff7xs45f8BSHT/EKuNoCLEUGjwDeiOqgT1K1RNOJ0t4w+imjBW5Dp Araxnz1zs3AekpSOxBHOE36mXBXjgQhxoCFyeGIs+7yVSvJHJ2UcHEy8+jbkEY6aRXx1 bdmO5jIK1f7iXAF+jSofxDJHQXNDj3sFRo3ESRznHm+Mw2GK07B4ef1mfHJN1GQNB19H xxPloN4XLEtD0jN52XOU3+RR/q8YlkLgC1o/RGdhTisbtqT7e4XyKYpPJgL74IQFnf/Q ByGQ== X-Gm-Message-State: AOAM530kCGmLRju7J55OMFK9TO3wNpf7livup8Ize2h9nJekpffZ3+cG M5v6IzseK/+uCyIDJNDIsjVXXg== X-Google-Smtp-Source: ABdhPJz+8ZHqxxjGU86tyolNaSdy9VlLyxBEJo+yDX15pPrPdOO0ZWJWGxlkjLP/OhHNkko5BhKtfA== X-Received: by 2002:a9d:2c61:: with SMTP id f88mr3251914otb.62.1627050257958; Fri, 23 Jul 2021 07:24:17 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id s7sm3420836ool.14.2021.07.23.07.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 07:24:17 -0700 (PDT) Date: Fri, 23 Jul 2021 09:24:14 -0500 From: Bjorn Andersson To: Saravana Kannan Cc: John Stultz , Greg Kroah-Hartman , lkml , Catalin Marinas , Will Deacon , Andy Gross , Joerg Roedel , Thomas Gleixner , Marc Zyngier , Linus Walleij , Vinod Koul , Kalle Valo , Maulik Shah , Todd Kjos , linux-arm-msm , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , "open list:GPIO SUBSYSTEM" Subject: Re: [PATCH] firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module Message-ID: References: <20210707045320.529186-1-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 21 Jul 16:07 CDT 2021, Saravana Kannan wrote: > On Wed, Jul 21, 2021 at 1:23 PM Bjorn Andersson > wrote: > > > > On Wed 21 Jul 13:00 CDT 2021, Saravana Kannan wrote: > > > > > On Wed, Jul 21, 2021 at 10:24 AM John Stultz wrote: > > > > > > > > On Wed, Jul 21, 2021 at 4:54 AM Greg Kroah-Hartman > > > > wrote: > > > > > > > > > > On Wed, Jul 07, 2021 at 04:53:20AM +0000, John Stultz wrote: > > > > > > Allow the qcom_scm driver to be loadable as a permenent module. > > > > > > > > > > This feels like a regression, it should be allowed to be a module. > > > > > > > > I'm sorry, I'm not sure I'm following you, Greg. This patch is trying > > > > to enable the driver to be able to be loaded as a module. > > > > > > I think the mix up might be that Greg mentally read "permanent module" > > > as "builtin"? > > > > > > "permanent module" is just something that can't be unloaded once it's > > > loaded. It's not "builtin". > > > > > > > Afaict there's nothing in this patch that makes it more or less > > permanent. > > The lack of a module_exit() makes it a permanent module. If you do > lsmod, it'll mark this as "[permanent]". > Cool, I didn't know that. Thanks, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E16BC4338F for ; Fri, 23 Jul 2021 14:24:26 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BC9360EBC for ; Fri, 23 Jul 2021 14:24:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3BC9360EBC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EDAFC4063D; Fri, 23 Jul 2021 14:24:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NoaJ1C8oH3De; Fri, 23 Jul 2021 14:24:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id DFE1040633; Fri, 23 Jul 2021 14:24:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9DAD5C001A; Fri, 23 Jul 2021 14:24:21 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0D69DC000E for ; Fri, 23 Jul 2021 14:24:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id D64CD401FC for ; Fri, 23 Jul 2021 14:24:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ThRqSL08Y-1c for ; Fri, 23 Jul 2021 14:24:19 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by smtp2.osuosl.org (Postfix) with ESMTPS id 00EBF401DB for ; Fri, 23 Jul 2021 14:24:18 +0000 (UTC) Received: by mail-ot1-x32d.google.com with SMTP id x15-20020a05683000cfb02904d1f8b9db81so2142957oto.12 for ; Fri, 23 Jul 2021 07:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TFOUkgVe/De3oymeenLBuNPer+TUmPN7lpMy3blENNw=; b=kMYc3VLcZ8HQkeGDP4GCj08ozIhO820sv8drLzH/p0tt+jnIl+jqN4ig75T2p0lKw/ GbMiV85J/nc0wqsoDrAy0FBoq8f4oWdxggAf3+1YZZPlqb/CIQw5PVwLqx2g1fKTU/xJ 2zCvCUTIqjmHIwMlzDo3Cq42Eirw6Z6bccTo6dTdRcjCoYtQKxDXrejsuVsuSV7LCRQR tuD974zCr28piclys4fQ7Y+lvwA+YYLmvDQ7giWULxqVOoa7Wshd7pAgkk+NcwkU53VM XgANK5fQb4M+ZZKMo9j6bpevRaDl4Dkyn+6PvhDQZiXVmnZmgWeY7qgorQkOPqWuAEcY HFBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TFOUkgVe/De3oymeenLBuNPer+TUmPN7lpMy3blENNw=; b=aSnj7In8zTwCxSAG9rYsH+smag5d567N/PwAaDMumskiRz/IAaCz6iyndN/rUJ95Ux Qa7Imyk9C/02y2Wro7FFfL45L7kx7y3rrnR7VToSmsuBFSGRvyrS9nR4knaaP9n4Fkhn 2MuNTp51YkgktTjBIlqLBajg/6g5Qid+Evq6O4W4NBI2RCxRzL/iiakQTcnp8ztiyxyc QLSmAgUAt8azva/ty5BODQVTqnmaSdppX12Rd9DNJjfMAokG7zO4HPblTD8uTNSuX9Oq ltDhhmzchWYyCWjP6buWI6pyc9a7Fnl6317o+g98EEg8WcAA1kRGf+279Sa+DzW3nduY Jf9g== X-Gm-Message-State: AOAM532tg/MB+1LeSE/N6XRAHpg+kwFaROXKrGxU2d4SFJK14+a0liwv IuHfxIwYv81lq95Fot6uFY6mBg== X-Google-Smtp-Source: ABdhPJz+8ZHqxxjGU86tyolNaSdy9VlLyxBEJo+yDX15pPrPdOO0ZWJWGxlkjLP/OhHNkko5BhKtfA== X-Received: by 2002:a9d:2c61:: with SMTP id f88mr3251914otb.62.1627050257958; Fri, 23 Jul 2021 07:24:17 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id s7sm3420836ool.14.2021.07.23.07.24.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jul 2021 07:24:17 -0700 (PDT) Date: Fri, 23 Jul 2021 09:24:14 -0500 From: Bjorn Andersson To: Saravana Kannan Subject: Re: [PATCH] firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module Message-ID: References: <20210707045320.529186-1-john.stultz@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Maulik Shah , Marc Zyngier , Greg Kroah-Hartman , lkml , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , "open list:GPIO SUBSYSTEM" , Vinod Koul , Andy Gross , John Stultz , Catalin Marinas , linux-arm-msm , Thomas Gleixner , Will Deacon , Linus Walleij , Kalle Valo , Todd Kjos X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed 21 Jul 16:07 CDT 2021, Saravana Kannan wrote: > On Wed, Jul 21, 2021 at 1:23 PM Bjorn Andersson > wrote: > > > > On Wed 21 Jul 13:00 CDT 2021, Saravana Kannan wrote: > > > > > On Wed, Jul 21, 2021 at 10:24 AM John Stultz wrote: > > > > > > > > On Wed, Jul 21, 2021 at 4:54 AM Greg Kroah-Hartman > > > > wrote: > > > > > > > > > > On Wed, Jul 07, 2021 at 04:53:20AM +0000, John Stultz wrote: > > > > > > Allow the qcom_scm driver to be loadable as a permenent module. > > > > > > > > > > This feels like a regression, it should be allowed to be a module. > > > > > > > > I'm sorry, I'm not sure I'm following you, Greg. This patch is trying > > > > to enable the driver to be able to be loaded as a module. > > > > > > I think the mix up might be that Greg mentally read "permanent module" > > > as "builtin"? > > > > > > "permanent module" is just something that can't be unloaded once it's > > > loaded. It's not "builtin". > > > > > > > Afaict there's nothing in this patch that makes it more or less > > permanent. > > The lack of a module_exit() makes it a permanent module. If you do > lsmod, it'll mark this as "[permanent]". > Cool, I didn't know that. Thanks, Bjorn _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu